Skip to content

Commit 5e39ff8

Browse files
committed
vscode: Fix update check timeouts
Forgot an extra 60 in the check interval and the notification timeout. Very unfortunate. Check has been allowed every 168 minutes instead of every week.
1 parent 3e22109 commit 5e39ff8

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

ci/dev/vscode.patch

+3-3
Original file line numberDiff line numberDiff line change
@@ -769,7 +769,7 @@ index 096b9e23493539c9937940a56e555d95bbae38d9..ef37e614004f550f7b64eacd362f6894
769769
remove(key: string, scope: StorageScope): void {
770770
diff --git a/src/vs/server/browser/client.ts b/src/vs/server/browser/client.ts
771771
new file mode 100644
772-
index 0000000000000000000000000000000000000000..bae5b43e07e33b24ed5cc62d39c6b929c0bc4e5f
772+
index 0000000000000000000000000000000000000000..bfc5f4d0c8bd7f6b9c4456f36b3b734c07859a60
773773
--- /dev/null
774774
+++ b/src/vs/server/browser/client.ts
775775
@@ -0,0 +1,241 @@
@@ -947,7 +947,7 @@ index 0000000000000000000000000000000000000000..bae5b43e07e33b24ed5cc62d39c6b929
947947
+ const lastNoti = storageService.getNumber("csLastUpdateNotification", StorageScope.GLOBAL);
948948
+ if (lastNoti) {
949949
+ // Only remind them again after 1 week.
950-
+ const timeout = 1000*60*24*7;
950+
+ const timeout = 1000*60*60*24*7;
951951
+ const threshold = lastNoti + timeout;
952952
+ if (Date.now() < threshold) {
953953
+ return;
@@ -966,7 +966,7 @@ index 0000000000000000000000000000000000000000..bae5b43e07e33b24ed5cc62d39c6b929
966966
+ logService.debug(`failed to check for update: ${error}`);
967967
+ }).finally(() => {
968968
+ // Check again every 6 hours.
969-
+ setTimeout(updateLoop, 1000*60*6);
969+
+ setTimeout(updateLoop, 1000*60*60*6);
970970
+ });
971971
+ };
972972
+

0 commit comments

Comments
 (0)