Skip to content

Commit 5dc9fb4

Browse files
nol166code-asher
authored andcommitted
Fix no-auth to still use HTTPS, set default for no-auth to false (#573)
1 parent ef9d60b commit 5dc9fb4

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

packages/server/src/cli.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ commander.version(process.env.VERSION || "development")
2626
.option("-h, --host <value>", "Customize the hostname.", "0.0.0.0")
2727
.option("-o, --open", "Open in the browser on startup.", false)
2828
.option("-p, --port <number>", "Port to bind on.", parseInt(process.env.PORT!, 10) || 8443)
29-
.option("-N, --no-auth", "Start without requiring authentication.", undefined)
29+
.option("-N, --no-auth", "Start without requiring authentication.", false)
3030
.option("-H, --allow-http", "Allow http connections.", false)
3131
.option("-P, --password <value>", "DEPRECATED: Use the PASSWORD environment variable instead. Specify a password for authentication.")
3232
.option("--disable-telemetry", "Disables ALL telemetry.", false)

packages/server/src/server.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,7 @@ export const createApp = async (options: CreateAppOptions): Promise<{
133133
});
134134
});
135135

136-
const server = httpolyglot.createServer(options.bypassAuth ? {} : options.httpsOptions || certs, app) as http.Server;
136+
const server = httpolyglot.createServer(options.allowHttp ? {} : options.httpsOptions || certs, app) as http.Server;
137137
const wss = new ws.Server({ server });
138138

139139
wss.shouldHandle = (req): boolean => {

0 commit comments

Comments
 (0)