fixup!: move lint-sh to scripts.yaml

Author: jsjoeio

.github/workflows/build.yaml

@@ -88,50 +88,6 @@ jobs:
         if: failure()
         uses: andymckay/[email protected]
 
-  lint-sh:
-    name: Lint shell files
-    runs-on: ubuntu-latest
-    timeout-minutes: 5
-    steps:
-      - name: Checkout repo
-        uses: actions/checkout@v3
-
-      - name: Get changed files
-        id: changed-files
-        uses: tj-actions/[email protected]
-        with:
-          files: |
-            **/*.sh
-            **/*.bats
-
-      - name: Install Node.js v16
-        if: steps.changed-files.outputs.any_changed == 'true'
-        uses: actions/setup-node@v3
-        with:
-          node-version: "16"
-
-      - name: Fetch dependencies from cache
-        if: steps.changed-files.outputs.any_changed == 'true'
-        id: cache-node-modules
-        uses: actions/cache@v3
-        with:
-          path: "**/node_modules"
-          key: yarn-build-${{ hashFiles('**yarn.lock') }}
-          restore-keys: |
-            yarn-build-
-
-      - name: Install dependencies
-        if: steps.changed-files.outputs.any_changed == 'true' && steps.cache-node-modules.outputs.cache-hit != 'true'
-        run: SKIP_SUBMODULE_DEPS=1 yarn --frozen-lockfile
-
-      - name: Lint shell files
-        if: steps.changed-files.outputs.any_changed == 'true'
-        run: yarn lint:sh
-
-      - name: Fail workflow
-        if: failure()
-        uses: andymckay/[email protected]
-
   lint-ts:
     name: Lint TypeScript files
     runs-on: ubuntu-latest

.github/workflows/scripts.yaml

@@ -51,3 +51,31 @@ jobs:
 
       - name: Run script unit tests
         run: ./ci/dev/test-scripts.sh
+  lint:
+    name: Lint shell files
+    runs-on: ubuntu-latest
+    timeout-minutes: 5
+    steps:
+      - name: Checkout repo
+        uses: actions/checkout@v3
+
+      - name: Install Node.js v16
+        uses: actions/setup-node@v3
+        with:
+          node-version: "16"
+
+      - name: Fetch dependencies from cache
+        id: cache-node-modules
+        uses: actions/cache@v3
+        with:
+          path: "**/node_modules"
+          key: yarn-build-${{ hashFiles('**yarn.lock') }}
+          restore-keys: |
+            yarn-build-
+
+      - name: Install dependencies
+        if: steps.cache-node-modules.outputs.cache-hit != 'true'
+        run: SKIP_SUBMODULE_DEPS=1 yarn --frozen-lockfile
+
+      - name: Lint shell files
+        run: yarn lint:sh