Skip to content

Commit 568ade7

Browse files
committed
Incorporate feedback
1 parent ce93e21 commit 568ade7

File tree

2 files changed

+15
-12
lines changed

2 files changed

+15
-12
lines changed

README.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ Run [VS Code](https://github.com/Microsoft/vscode) on any machine anywhere and a
1515
There are two ways to get started:
1616

1717
1. Using the [install script](./install.sh), which automates most of the process. The script uses the system package manager (if possible)
18-
2. Manually installing code-server; see [Installation](./doc/install.md#quick-install) for instructions applicable to most use cases
18+
2. Manually installing code-server; see [Installation](./doc/install.md) for instructions applicable to most use cases
1919

2020
If you choose to use the install script, you can preview what occurs during the install process:
2121

@@ -47,7 +47,7 @@ See [./doc/FAQ.md](./doc/FAQ.md).
4747

4848
## Want to help?
4949

50-
See [CONTRIBUTING](./doc/CONTRIBUTING.md) for additional details.
50+
See [CONTRIBUTING](./doc/CONTRIBUTING.md) for details.
5151

5252
## Hiring
5353

doc/CONTRIBUTING.md

+13-10
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,14 @@
22
<!-- DON'T EDIT THIS SECTION, INSTEAD RE-RUN doctoc TO UPDATE -->
33
# Contributing
44

5-
- [Pull Requests](#pull-requests)
6-
- [Requirements](#requirements)
7-
- [Development Workflow](#development-workflow)
8-
- [Build](#build)
9-
- [Structure](#structure)
10-
- [VS Code Patch](#vs-code-patch)
11-
- [Currently Known Issues](#currently-known-issues)
5+
- [Contributing](#contributing)
6+
- [Pull Requests](#pull-requests)
7+
- [Requirements](#requirements)
8+
- [Development Workflow](#development-workflow)
9+
- [Build](#build)
10+
- [Structure](#structure)
11+
- [VS Code Patch](#vs-code-patch)
12+
- [Currently Known Issues](#currently-known-issues)
1213

1314
<!-- END doctoc generated TOC please keep comment here to allow auto update -->
1415

@@ -126,7 +127,7 @@ and exposed an API to the front-end for file access and all UI needs.
126127

127128
Over time, Microsoft added support to VS Code to run it on the web. They have made
128129
the front-end open source, but not the server. As such, code-server v2 (and later) uses
129-
the VS Code front-end and fills in with the server. You can find this in
130+
the VS Code front-end and implements the server. You can find this in
130131
[./ci/dev/vscode.patch](../ci/dev/vscode.patch) under the path `src/vs/server`.
131132

132133
Other notable changes in our patch include:
@@ -144,8 +145,10 @@ Other notable changes in our patch include:
144145
- Adding connection type to web socket query parameters
145146

146147
As the web portion of VS Code matures, we'll be able to shrink and possibly
147-
eliminate our patch. In the meantime, upgrading the VS Code version requires us to ensure that the patch is applied and works as intended. In the future, we'd like to run VS
148-
Code unit tests against our builds to ensure that features work as expected.
148+
eliminate our patch. In the meantime, upgrading the VS Code version requires
149+
us to ensure that the patch is applied and works as intended. In the future,
150+
we'd like to run VS Code unit tests against our builds to ensure that features
151+
work as expected.
149152

150153
To generate a new patch, run `yarn vscode:diff`
151154

0 commit comments

Comments
 (0)