Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit 504a56f

Browse files
committedNov 8, 2022
fixup!: add log to toCodeArgs
This was changed upstream from `string` to `string[]` so now we convert to an array in `toCodeArgs`. See 78c02a1
1 parent 43e71fb commit 504a56f

File tree

2 files changed

+3
-0
lines changed

2 files changed

+3
-0
lines changed
 

‎src/node/cli.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -814,6 +814,7 @@ export interface CodeArgs extends UserProvidedCodeArgs {
814814
"without-connection-token"?: boolean
815815
"without-browser-env-var"?: boolean
816816
compatibility: string
817+
log: string[] | undefined
817818
}
818819

819820
/**
@@ -835,5 +836,6 @@ export const toCodeArgs = async (args: DefaultedArgs): Promise<CodeArgs> => {
835836
help: !!args.help,
836837
version: !!args.version,
837838
port: args.port?.toString(),
839+
log: args.log ? [args.log] : undefined,
838840
}
839841
}

‎test/unit/node/cli.test.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -795,6 +795,7 @@ describe("toCodeArgs", () => {
795795
help: false,
796796
port: "8080",
797797
version: false,
798+
log: undefined,
798799
}
799800

800801
const testName = "vscode-args"

0 commit comments

Comments
 (0)
Please sign in to comment.