update.ts: Fix response memory leak

nhooyr · nhooyr · commit 4b56385d286c · 2020-12-04T02:12:50.000-05:00
diff --git a/src/node/update.ts b/src/node/update.ts
@@ -106,12 +106,13 @@ export class UpdateProvider {
         const httpx = uri.startsWith("https") ? https : http
         const client = httpx.get(uri, { headers: { "User-Agent": "code-server" } }, (response) => {
           if (!response.statusCode || response.statusCode < 200 || response.statusCode >= 400) {
+            response.destroy()
             return reject(new Error(`${uri}: ${response.statusCode || "500"}`))
           }
 
           if (response.statusCode >= 300) {
-            ++redirects
             response.destroy()
+            ++redirects
             if (redirects > maxRedirects) {
               return reject(new Error("reached max redirects"))
             }

Original file line number	Diff line number	Diff line change
`@@ -106,12 +106,13 @@ export class UpdateProvider {`
`106`	`106`	`const httpx = uri.startsWith("https") ? https : http`
`107`	`107`	`const client = httpx.get(uri, { headers: { "User-Agent": "code-server" } }, (response) => {`
`108`	`108`	`if (!response.statusCode \|\| response.statusCode < 200 \|\| response.statusCode >= 400) {`
	`109`	`+ response.destroy()`
`109`	`110`	return reject(new Error(`${uri}: ${response.statusCode \|\| "500"}`))
`110`	`111`	`}`
`111`	`112`
`112`	`113`	`if (response.statusCode >= 300) {`
`113`		`- ++redirects`
`114`	`114`	`response.destroy()`
	`115`	`+ ++redirects`
`115`	`116`	`if (redirects > maxRedirects) {`
`116`	`117`	`return reject(new Error("reached max redirects"))`
`117`	`118`	`}`