Fix human readable byte size when zero

code-asher · code-asher · commit 4a29cd166436 · 2019-05-20T15:53:06.000-05:00
diff --git a/packages/vscode/src/dialog.ts b/packages/vscode/src/dialog.ts
@@ -505,9 +505,8 @@ class DialogEntryRenderer implements ITreeRenderer<DialogEntry, string, DialogEn
 	 */
 	private humanReadableSize(bytes: number): string {
 		const units = ["B", "KB", "MB", "GB", "TB", "PB", "EB", "ZB", "YB"];
-		const i = Math.min(Math.floor(Math.log(bytes) / Math.log(1000)), units.length - 1);
+		const i = Math.min(Math.floor(bytes && Math.log(bytes) / Math.log(1000)), units.length - 1);
 
-		return (bytes / Math.pow(1000, i)).toFixed(2)
-			+ " " + units[i];
+		return (bytes / Math.pow(1000, i)).toFixed(2) + " " + units[i];
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -505,9 +505,8 @@ class DialogEntryRenderer implements ITreeRenderer<DialogEntry, string, DialogEn`
`505`	`505`	`*/`
`506`	`506`	`private humanReadableSize(bytes: number): string {`
`507`	`507`	`const units = ["B", "KB", "MB", "GB", "TB", "PB", "EB", "ZB", "YB"];`
`508`		`- const i = Math.min(Math.floor(Math.log(bytes) / Math.log(1000)), units.length - 1);`
	`508`	`+ const i = Math.min(Math.floor(bytes && Math.log(bytes) / Math.log(1000)), units.length - 1);`
`509`	`509`
`510`		`- return (bytes / Math.pow(1000, i)).toFixed(2)`
`511`		`- + " " + units[i];`
	`510`	`+ return (bytes / Math.pow(1000, i)).toFixed(2) + " " + units[i];`
`512`	`511`	`}`
`513`	`512`	`}`