Skip to content

Commit 35c9fd1

Browse files
committed
Fix Travis build script
1 parent 9af553e commit 35c9fd1

File tree

4 files changed

+17
-8
lines changed

4 files changed

+17
-8
lines changed

.travis.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ before_install:
2121
libsecret-1-dev; fi
2222
- npm install -g [email protected]
2323
script:
24-
- scripts/build.sh
24+
- scripts/build.bash
2525
before_deploy:
2626
- echo "$VERSION" "$TRAVIS_COMMIT"
2727
- git config --local user.name "$USER_NAME"

package.json

+1
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
"postinstall": "yarn build:rules",
1111
"build": "yarn task build",
1212
"bundle": "yarn task bundle",
13+
"package": "yarn task package",
1314
"start": "npm-run-all --parallel watch build:run",
1415
"watch": "yarn task build true",
1516
"build:run": "cd ./out && node ./packages/server/src/cli # TODO: restart on change",

scripts/build.bash

+8-5
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,9 @@ function docker_build() {
1818
docker cp ./. "${containerId}":/src
1919
docker_exec "cd /src && yarn"
2020
docker_exec "cd /src && npm rebuild"
21-
docker_exec "cd /src && NODE_ENV=production VERSION=${version} yarn task build:server:binary"
22-
docker_exec "cd /src && yarn task package ${version}"
21+
docker_exec "cd /src && NODE_ENV=production VERSION=${version} yarn build"
22+
docker_exec "cd /src && yarn bundle"
23+
docker_exec "cd /src && yarn package ${version}"
2324
docker cp "${containerId}":/src/release/. ./release/
2425

2526
docker stop "${containerId}"
@@ -28,18 +29,20 @@ function docker_build() {
2829
function main() {
2930
local version=${VERSION:-}
3031
local ostype=${OSTYPE:-}
32+
local target=${TARGET:-}
3133

3234
if [[ -z "${version}" ]] ; then
3335
>&2 echo "Must set VERSION environment variable"
3436
exit 1
3537
fi
3638

3739
if [[ "${ostype}" == "darwin"* ]]; then
38-
NODE_ENV=production VERSION="${version}" yarn task build:server:binary
39-
yarn task package "${version}"
40+
NODE_ENV=production VERSION="${version}" yarn build
41+
yarn bundle
42+
yarn package "${version}"
4043
else
4144
local image
42-
if [[ "$TARGET" == "alpine" ]]; then
45+
if [[ "${target}" == "alpine" ]]; then
4346
image="codercom/nbin-alpine"
4447
else
4548
image="codercom/nbin-centos"

scripts/tasks.ts

+7-2
Original file line numberDiff line numberDiff line change
@@ -153,8 +153,13 @@ const ensureInstalled = register("vscode:install", async (runner, logger) => {
153153
}));
154154
break;
155155
case 404:
156-
logger.info(`VS Code ${vscodeVersion} hasn't been packaged yet`);
157-
clone().then(() => build()).catch(reject);
156+
const message = `VS Code ${vscodeVersion} hasn't been packaged yet`;
157+
if (!process.env.CI) {
158+
logger.warn(message);
159+
clone().then(() => build()).catch(reject);
160+
} else {
161+
reject(new Error(message));
162+
}
158163
break;
159164
default:
160165
return reject(new Error(res.statusMessage));

0 commit comments

Comments
 (0)