Skip to content

Commit 2481711

Browse files
committed
Add platform to vscode-reh-web task
Our strategy has been to build once and then recompile native modules for individual platforms. It looks like VS Code builds from scratch for each platform. But we can target any platform, grab the pre-packaged folder, then continue with own packaging. In the future we may want to rework to match upstream.
1 parent 062ce32 commit 2481711

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

ci/build/build-release.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ EOF
6868
bundle_vscode() {
6969
mkdir -p "$VSCODE_OUT_PATH"
7070
rsync "$VSCODE_SRC_PATH/yarn.lock" "$VSCODE_OUT_PATH"
71-
rsync "$VSCODE_SRC_PATH/out-vscode-server${MINIFY:+-min}/" "$VSCODE_OUT_PATH/out"
71+
rsync "$VSCODE_SRC_PATH/out-vscode-reh-web${MINIFY:+-min}/" "$VSCODE_OUT_PATH/out"
7272

7373
rsync "$VSCODE_SRC_PATH/.build/extensions/" "$VSCODE_OUT_PATH/extensions"
7474
if [ "$KEEP_MODULES" = 0 ]; then

ci/build/build-vscode.sh

+2-3
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,8 @@ main() {
1111

1212
cd vendor/modules/code-oss-dev
1313

14-
# extensions-ci compiles extensions and includes their media.
15-
# compile-web compiles web extensions. TODO: Unsure if used.
16-
yarn gulp extensions-ci compile-web "vscode-reh-web${MINIFY:+-min}"
14+
# Any platform works since we have our own packaging step (for now).
15+
yarn gulp "vscode-reh-web-linux-x64${MINIFY:+-min}"
1716
}
1817

1918
main "$@"

0 commit comments

Comments
 (0)