Merge pull request #3378 from cdr/jsjoeio/milestones-issues

docs(maintaining): add pull requests section

Author: jsjoeio

CHANGELOG.md

@@ -68,6 +68,8 @@ VS Code v1.56
 ### Documentation
 
 - docs(install): add raspberry pi section #3376 @jsjoeio
+- docs(maintaining): add pull requests section #3378 @jsjoeio
+- docs(maintaining): add merge strategies section #3379 @jsjoeio
 
 ### Development
 

docs/MAINTAINING.md

@@ -8,6 +8,8 @@
     - [Triage](#triage)
     - [Project Boards](#project-boards)
   - [Versioning](#versioning)
+  - [Pull Requests](#pull-requests)
+    - [Merge Strategies](#merge-strategies)
 
 <!-- END doctoc generated TOC please keep comment here to allow auto update -->
 
@@ -62,4 +64,14 @@ It also gives us a way to separate the issue triage from bigger-picture, long-te
 
 `<major.minor.patch>`
 
-The code-server project follows traditional [semantic versioning](ttps://semver.org/), with the objective of minimizing major changes that break backward compatibility. We increment the patch level for all releases, except when the upstream Visual Studio Code project increments its minor version or we change the plugin API in a backward-compatible manner. In those cases, we increment the minor version rather than the patch level.
+The code-server project follows traditional [semantic versioning](https://semver.org/), with the objective of minimizing major changes that break backward compatibility. We increment the patch level for all releases, except when the upstream Visual Studio Code project increments its minor version or we change the plugin API in a backward-compatible manner. In those cases, we increment the minor version rather than the patch level.
+
+## Pull Requests
+
+Ideally, every PR should fix an issue. If it doesn't, make sure it's associated with a version milestone.
+
+If a PR does fix an issue, don't add it to the version milestone. Otherwise, the version milestone will have duplicate information: the issue & the PR fixing the issue.
+
+### Merge Strategies
+
+For most things, we recommend "Squash and Merge". If you're updating `lib/vscode`, we suggest using the "Rebase and Merge" strategy. There may be times where "Create a merge commit" makes sense as well. Use your best judgement. If you're unsure, you can always discuss in the PR with the team.