Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit 0f66360

Browse files
committedDec 2, 2022
fix: keep product.json file permissions in release
When we added the change to modify the `package.json` version using `mv` and `jq` we didn't account for lost file permissions. This caused a bug only happening in CI. This should fix it by giving it 755 via `chmod`.
1 parent 130f52e commit 0f66360

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed
 

‎.github/workflows/release.yaml

+2
Original file line numberDiff line numberDiff line change
@@ -322,6 +322,8 @@ jobs:
322322
echo "Updating version in lib/vscode/product.json"
323323
tmp=$(mktemp)
324324
jq '.codeServerVersion = "$VERSION"' release/lib/vscode/product.json > "$tmp" && mv "$tmp" release/lib/vscode/product.json
325+
# Ensure it has the same permissions as before
326+
chmod 755 release/lib/vscode/product.json
325327
326328
- name: Compress release package
327329
run: tar -czf package.tar.gz release

0 commit comments

Comments
 (0)
Please sign in to comment.