Skip to content

Commit 0de898f

Browse files
committed
refactor: pass codeServerArgs to e2e CodeServer
1 parent c827095 commit 0de898f

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

test/e2e/baseFixture.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ import { CodeServer, CodeServerPage } from "./models/CodeServer"
1212
export const describe = (name: string, includeCredentials: boolean, codeServerArgs: string[], fn: (codeServer: CodeServer) => void) => {
1313
test.describe(name, () => {
1414
// This will spawn on demand so nothing is necessary on before.
15-
const codeServer = new CodeServer(name)
15+
const codeServer = new CodeServer(name, codeServerArgs)
1616

1717
// Kill code-server after the suite has ended. This may happen even without
1818
// doing it explicitly but it seems prudent to be sure.

test/e2e/models/CodeServer.ts

+2-1
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ export class CodeServer {
3131
public readonly logger: Logger
3232
private closed = false
3333

34-
constructor(name: string) {
34+
constructor(name: string, private codeServerArgs: string[]) {
3535
this.logger = logger.named(name)
3636
}
3737

@@ -77,6 +77,7 @@ export class CodeServer {
7777
const proc = cp.spawn(
7878
"node",
7979
[
80+
...this.codeServerArgs,
8081
process.env.CODE_SERVER_TEST_ENTRY || ".",
8182
// Using port zero will spawn on a random port.
8283
"--bind-addr",

0 commit comments

Comments
 (0)