Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit 096feb7

Browse files
committedMar 21, 2022
Add links to matching Code types
1 parent 03d6559 commit 096feb7

File tree

3 files changed

+11
-5
lines changed

3 files changed

+11
-5
lines changed
 

‎src/node/cli.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -767,6 +767,8 @@ export const shouldOpenInExistingInstance = async (args: UserProvidedArgs): Prom
767767

768768
/**
769769
* Arguments for running Code's server.
770+
*
771+
* A subset of ../../lib/vscode/src/vs/server/node/serverEnvironmentService.ts:90
770772
*/
771773
export interface CodeArgs extends UserProvidedCodeArgs {
772774
"accept-server-license-terms"?: boolean
@@ -779,7 +781,7 @@ export interface CodeArgs extends UserProvidedCodeArgs {
779781
}
780782

781783
/**
782-
* Spawn the Code CLI.
784+
* Types for ../../lib/vscode/src/vs/server/node/server.main.ts:65.
783785
*/
784786
export type SpawnCodeCli = (args: CodeArgs) => Promise<void>
785787

‎src/node/main.ts

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,13 @@ export const shouldSpawnCliProcess = (args: UserProvidedArgs): boolean => {
2424
}
2525

2626
/**
27+
* This is copy of OpenCommandPipeArgs from
28+
* ../../lib/vscode/src/vs/workbench/api/node/extHostCLIServer.ts:15
29+
*
2730
* Arguments supported by Code's socket. It can be used to perform actions from
2831
* the CLI in a running instance of Code (for example to open a file).
32+
*
33+
* TODO: Can we import this (and other types) directly?
2934
*/
3035
export interface OpenCommandPipeArgs {
3136
type: "open"
@@ -45,7 +50,7 @@ export interface OpenCommandPipeArgs {
4550
export const runCodeCli = async (args: DefaultedArgs): Promise<void> => {
4651
logger.debug("Running Code CLI")
4752

48-
// See ../../lib/vscode/src/vs/server/node/server.main.js.
53+
// See ../../lib/vscode/src/vs/server/node/server.main.ts:65.
4954
const spawnCli = await loadAMDModule<SpawnCodeCli>("vs/server/node/server.main", "spawnCli")
5055

5156
try {

‎src/node/routes/vscode.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ export interface IServerAPI {
2323
dispose(): void
2424
}
2525

26+
// Types for ../../../lib/vscode/src/vs/server/node/server.main.ts:72.
2627
export type CreateServer = (address: string | net.AddressInfo | null, args: CodeArgs) => Promise<IServerAPI>
2728

2829
export class CodeServerRouteWrapper {
@@ -146,9 +147,7 @@ export class CodeServerRouteWrapper {
146147

147148
const { args } = req
148149

149-
/**
150-
* @file ../../../lib/vscode/src/vs/server/node/server.main.js
151-
*/
150+
// See ../../../lib/vscode/src/vs/server/node/server.main.ts:72.
152151
const createVSServer = await loadAMDModule<CreateServer>("vs/server/node/server.main", "createServer")
153152

154153
try {

0 commit comments

Comments
 (0)
Please sign in to comment.