Remove compilation check

If you do a regular non-watch build there are no compilation stats so
this bricks VS Code in CI when running the unit tests.

I am not sure how best to fix this for the case where you have a build
that has not been packaged yet so I just removed it for now and added a
message to check if VS Code is compiling when in dev mode.

Author: code-asher

ci/dev/watch.ts

@@ -1,7 +1,7 @@
 import { spawn, fork, ChildProcess } from "child_process"
 import { promises as fs } from "fs"
 import * as path from "path"
-import { CompilationStats, onLine, OnLineCallback } from "../../src/node/util"
+import { onLine, OnLineCallback } from "../../src/node/util"
 
 interface DevelopmentCompilers {
   [key: string]: ChildProcess | undefined
@@ -16,7 +16,6 @@ class Watcher {
   private readonly paths = {
     /** Path to uncompiled VS Code source. */
     vscodeDir: path.join(this.rootPath, "vendor", "modules", "code-oss-dev"),
-    compilationStatsFile: path.join(this.rootPath, "out", "watcher.json"),
     pluginDir: process.env.PLUGIN_DIR,
   }
 
@@ -88,7 +87,6 @@ class Watcher {
 
     if (strippedLine.includes("Finished compilation with")) {
       console.log("[VS Code] ✨ Finished compiling! ✨", "(Refresh your web browser ♻️)")
-      this.emitCompilationStats()
       this.reloadWebServer()
     }
   }
@@ -118,19 +116,6 @@ class Watcher {
 
   //#region Utilities
 
-  /**
-   * Emits a file containing compilation data.
-   * This is especially useful when Express needs to determine if VS Code is still compiling.
-   */
-  private emitCompilationStats(): Promise<void> {
-    const stats: CompilationStats = {
-      lastCompiledAt: new Date(),
-    }
-
-    console.log("Writing watcher stats...")
-    return fs.writeFile(this.paths.compilationStatsFile, JSON.stringify(stats, null, 2))
-  }
-
   private dispose(code: number | null): void {
     for (const [processName, devProcess] of Object.entries(this.compilers)) {
       console.log(`[${processName}]`, "Killing...\n")

src/node/routes/vscode.ts

@@ -5,7 +5,7 @@ import { logError } from "../../common/util"
 import { toVsCodeArgs } from "../cli"
 import { isDevMode } from "../constants"
 import { authenticated, ensureAuthenticated, redirect, self } from "../http"
-import { loadAMDModule, readCompilationStats } from "../util"
+import { loadAMDModule } from "../util"
 import { Router as WsRouter } from "../wsRouter"
 import { errorHandler } from "./errors"
 
@@ -93,15 +93,6 @@ export class CodeServerRouteWrapper {
       return next()
     }
 
-    if (isDevMode) {
-      // Is the development mode file watcher still busy?
-      const compileStats = await readCompilationStats()
-
-      if (!compileStats || !compileStats.lastCompiledAt) {
-        return next(new Error("VS Code may still be compiling..."))
-      }
-    }
-
     // Create the server...
 
     const { args } = req
@@ -118,6 +109,9 @@ export class CodeServerRouteWrapper {
       this._codeServerMain = await createVSServer(null, await toVsCodeArgs(args))
     } catch (createServerError) {
       logError(logger, "CodeServerRouteWrapper", createServerError)
+      if (isDevMode) {
+        return next(new Error(createServerError.message + " (VS Code may still be compiling)"))
+      }
       return next(createServerError)
     }
 

src/node/util.ts

@@ -11,7 +11,7 @@ import safeCompare from "safe-compare"
 import * as util from "util"
 import xdgBasedir from "xdg-basedir"
 import { logError } from "../common/util"
-import { isDevMode, rootPath, vsRootPath } from "./constants"
+import { rootPath, vsRootPath } from "./constants"
 
 export interface Paths {
   data: string
@@ -523,34 +523,3 @@ export const loadAMDModule = async <T>(amdPath: string, exportName: string): Pro
 
   return module[exportName] as T
 }
-
-export interface CompilationStats {
-  lastCompiledAt: Date
-}
-
-export const readCompilationStats = async (): Promise<null | CompilationStats> => {
-  if (!isDevMode) {
-    throw new Error("Compilation stats are only present in development")
-  }
-
-  const filePath = path.join(rootPath, "out/watcher.json")
-  let stat: Stats
-  try {
-    stat = await fs.stat(filePath)
-  } catch (error) {
-    return null
-  }
-
-  if (!stat.isFile()) {
-    return null
-  }
-
-  try {
-    const file = await fs.readFile(filePath)
-    return JSON.parse(file.toString("utf-8"))
-  } catch (error) {
-    logError(logger, "VS Code", error)
-  }
-
-  return null
-}