refactor: centralize normalize_focus and fix config inconsistencies

- Create shared claudecode.utils module with normalize_focus() function
- Remove duplicated normalize_focus() from snacks and native providers
- Update both providers to use utils.normalize_focus()
- Fix queue_timeout inconsistency: update tests to use 5000ms (matching config default)
- Maintain backward compatibility and functionality

This addresses Copilot feedback about duplicated code and config inconsistencies.

Change-Id: I6eb1496e680fb9c6d940d1b8baa62ab2eda9290f
Signed-off-by: Thomas Kosiewski <[email protected]>

Author: ThomasK33

lua/claudecode/terminal/native.lua

@@ -5,13 +5,7 @@
 local M = {}
 
 local logger = require("claudecode.logger")
-
---- Normalizes focus parameter to default to true for backward compatibility
---- @param focus boolean|nil The focus parameter
---- @return boolean Normalized focus value
-local function normalize_focus(focus)
-  return focus == nil and true or focus
-end
+local utils = require("claudecode.utils")
 
 local bufnr = nil
 local winid = nil
@@ -53,7 +47,7 @@ local function is_valid()
 end
 
 local function open_terminal(cmd_string, env_table, effective_config, focus)
-  focus = normalize_focus(focus)
+  focus = utils.normalize_focus(focus)
 
   if is_valid() then -- Should not happen if called correctly, but as a safeguard
     if focus then
@@ -269,7 +263,7 @@ end
 --- @param effective_config table
 --- @param focus boolean|nil
 function M.open(cmd_string, env_table, effective_config, focus)
-  focus = normalize_focus(focus)
+  focus = utils.normalize_focus(focus)
 
   if is_valid() then
     if focus then

lua/claudecode/terminal/snacks.lua

@@ -5,6 +5,7 @@
 local M = {}
 
 local snacks_available, Snacks = pcall(require, "snacks")
+local utils = require("claudecode.utils")
 local terminal = nil
 
 --- @return boolean
@@ -41,19 +42,12 @@ local function setup_terminal_events(term_instance, config)
   end, { buf = true })
 end
 
---- Normalizes focus parameter to default to true for backward compatibility
---- @param focus boolean|nil The focus parameter
---- @return boolean Normalized focus value
-local function normalize_focus(focus)
-  return focus == nil and true or focus
-end
-
 --- @param config table
 --- @param env_table table
 --- @param focus boolean|nil
 --- @return table
 local function build_opts(config, env_table, focus)
-  focus = normalize_focus(focus)
+  focus = utils.normalize_focus(focus)
   return {
     env = env_table,
     start_insert = focus,
@@ -82,7 +76,7 @@ function M.open(cmd_string, env_table, config, focus)
     return
   end
 
-  focus = normalize_focus(focus)
+  focus = utils.normalize_focus(focus)
 
   if terminal and terminal:buf_valid() then
     if focus then

lua/claudecode/utils.lua

@@ -0,0 +1,13 @@
+--- Shared utility functions for claudecode.nvim
+-- @module claudecode.utils
+
+local M = {}
+
+--- Normalizes focus parameter to default to true for backward compatibility
+--- @param focus boolean|nil The focus parameter
+--- @return boolean Normalized focus value
+function M.normalize_focus(focus)
+  return focus == nil and true or focus
+end
+
+return M

tests/config_test.lua

@@ -185,7 +185,7 @@ describe("Config module", function()
       visual_demotion_delay_ms = 50,
       connection_wait_delay = 200,
       connection_timeout = 10000,
-      queue_timeout = 3000,
+      queue_timeout = 5000,
       diff_opts = {
         auto_close_on_accept = true,
         show_diff_stats = true,

tests/unit/config_spec.lua

@@ -34,7 +34,7 @@ describe("Configuration", function()
       visual_demotion_delay_ms = 50,
       connection_wait_delay = 200,
       connection_timeout = 10000,
-      queue_timeout = 3000,
+      queue_timeout = 5000,
       diff_opts = {
         auto_close_on_accept = true,
         show_diff_stats = true,