Skip to content

Commit 593c27d

Browse files
authored
Merge pull request #39 from rogerhu/fix_intent
New intent:// scheme breaks this check. Disable for now
2 parents 44e0199 + 83f27e6 commit 593c27d

File tree

3 files changed

+5
-7
lines changed

3 files changed

+5
-7
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ Next, add this line to your `app/build.gradle` file:
2424

2525
```gradle
2626
dependencies {
27-
compile 'com.codepath.libraries:android-oauth-handler:1.2.3'
27+
compile 'com.codepath.libraries:android-oauth-handler:1.2.4'
2828
}
2929
```
3030

app/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ ext {
88

99
GROUP = 'com.codepath.libraries'
1010
BASE_VERSION = "1.2"
11-
VERSION_NAME = "1.2.3"
11+
VERSION_NAME = "1.2.4"
1212
POM_PACKAGING = "aar"
1313
POM_DESCRIPTION = "CodePath OAuth Handler"
1414

app/src/main/java/com/codepath/oauth/OAuthBaseClient.java

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -122,11 +122,9 @@ public void connect() {
122122
public void authorize(Uri uri, OAuthAccessHandler handler) {
123123
this.accessHandler = handler;
124124
if (checkAccessToken() == null && uri != null) {
125-
String uriServiceCallback = uri.getScheme() + "://" + uri.getHost();
126-
// check if the authorize callback matches this service before trying to get an access token
127-
if (uriServiceCallback.equals(callbackUrl)) {
128-
client.fetchAccessToken(getOAuth1RequestToken(), uri);
129-
}
125+
// TODO: check UriServiceCallback with intent:// scheme
126+
client.fetchAccessToken(getOAuth1RequestToken(), uri);
127+
130128
} else if (checkAccessToken() != null) { // already have access token
131129
this.accessHandler.onLoginSuccess();
132130
}

0 commit comments

Comments
 (0)