Skip to content

Commit dc873a4

Browse files
committed
Code analysis cleanup
1 parent 8527911 commit dc873a4

File tree

10 files changed

+18
-9
lines changed

10 files changed

+18
-9
lines changed

src/main/java/org/codehaus/plexus/archiver/filters/JarSecurityFileFilter.java

-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
import java.io.InputStream;
44

55
import org.codehaus.plexus.archiver.ArchiveFileFilter;
6-
import org.codehaus.plexus.archiver.ArchiveFilterException;
76
import org.codehaus.plexus.util.SelectorUtils;
87

98

src/main/java/org/codehaus/plexus/archiver/filters/JarSecurityFileSelector.java

+3-1
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,8 @@
1919
import org.codehaus.plexus.components.io.fileselectors.FileSelector;
2020
import org.codehaus.plexus.util.SelectorUtils;
2121

22+
import javax.annotation.Nonnull;
23+
2224
/**
2325
* @version $Id$
2426
* @since 1.0-alpha-9
@@ -36,7 +38,7 @@ public class JarSecurityFileSelector
3638
"META-INF/*.dsa",
3739
"META-INF/*.sf" };
3840

39-
public boolean isSelected( FileInfo fileInfo )
41+
public boolean isSelected( @Nonnull FileInfo fileInfo )
4042
throws IOException
4143
{
4244
String name = fileInfo.getName();

src/main/java/org/codehaus/plexus/archiver/resources/PlexusIoVirtualFileResource.java

+3
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,8 @@
2727
import org.codehaus.plexus.components.io.functions.ResourceAttributeSupplier;
2828
import org.codehaus.plexus.components.io.resources.AbstractPlexusIoResource;
2929

30+
import javax.annotation.Nonnull;
31+
3032
/**
3133
* A file resource that does not necessarily exist (anywhere).
3234
*/
@@ -55,6 +57,7 @@ public File getFile()
5557
return file;
5658
}
5759

60+
@Nonnull
5861
public InputStream getContents()
5962
throws IOException
6063
{

src/main/java/org/codehaus/plexus/archiver/tar/TarResource.java

+3
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,8 @@
1111
import org.codehaus.plexus.components.io.resources.AbstractPlexusIoResource;
1212
import org.codehaus.plexus.components.io.resources.PlexusIoResource;
1313

14+
import javax.annotation.Nonnull;
15+
1416
public class TarResource
1517
extends AbstractPlexusIoResource
1618
implements ResourceAttributeSupplier
@@ -55,6 +57,7 @@ public URL getURL()
5557
return null;
5658
}
5759

60+
@Nonnull
5861
public InputStream getContents()
5962
throws IOException
6063
{

src/main/java/org/codehaus/plexus/archiver/util/Compressor.java

-4
Original file line numberDiff line numberDiff line change
@@ -18,19 +18,15 @@
1818
*/
1919

2020
import java.io.File;
21-
import java.io.FileInputStream;
2221
import java.io.IOException;
2322
import java.io.InputStream;
2423
import java.io.OutputStream;
2524

2625
import org.codehaus.plexus.archiver.ArchiverException;
27-
import org.codehaus.plexus.components.io.resources.PlexusIoFileResource;
2826
import org.codehaus.plexus.components.io.resources.PlexusIoResource;
2927
import org.codehaus.plexus.logging.AbstractLogEnabled;
3028
import org.codehaus.plexus.util.IOUtil;
3129

32-
import static org.codehaus.plexus.components.io.resources.ResourceFactory.createResource;
33-
3430
/**
3531
* @version $Revision$ $Date$
3632
*/

src/main/java/org/codehaus/plexus/archiver/util/FilterSupport.java

-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
import java.util.List;
55

66
import org.codehaus.plexus.archiver.ArchiveFileFilter;
7-
import org.codehaus.plexus.archiver.ArchiveFilterException;
87
import org.codehaus.plexus.archiver.Archiver;
98
import org.codehaus.plexus.components.io.fileselectors.FileSelector;
109
import org.codehaus.plexus.logging.Logger;

src/main/java/org/codehaus/plexus/archiver/zip/AbstractZipUnArchiver.java

+3-1
Original file line numberDiff line numberDiff line change
@@ -28,11 +28,12 @@
2828
import org.apache.commons.compress.archivers.zip.ZipFile;
2929
import org.apache.commons.compress.utils.IOUtils;
3030
import org.codehaus.plexus.archiver.AbstractUnArchiver;
31-
import org.codehaus.plexus.archiver.ArchiveFilterException;
3231
import org.codehaus.plexus.archiver.ArchiverException;
3332
import org.codehaus.plexus.components.io.resources.PlexusIoResource;
3433
import org.codehaus.plexus.util.IOUtil;
3534

35+
import javax.annotation.Nonnull;
36+
3637
/**
3738
* @author <a href="mailto:[email protected]">Emmanuel Venisse</a>
3839
* @version $Id$
@@ -102,6 +103,7 @@ public boolean isSymbolicLink()
102103
return zipEntry.isUnixSymlink();
103104
}
104105

106+
@Nonnull
105107
public InputStream getContents()
106108
throws IOException
107109
{

src/main/java/org/codehaus/plexus/archiver/zip/AnonymousResource.java

+3
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77

88
import org.codehaus.plexus.components.io.resources.AbstractPlexusIoResource;
99

10+
import javax.annotation.Nonnull;
11+
1012
public class AnonymousResource extends AbstractPlexusIoResource {
1113

1214
private final File file;
@@ -22,6 +24,7 @@ public AnonymousResource(File file, String name)
2224
this.file = file;
2325
}
2426

27+
@Nonnull
2528
public InputStream getContents()
2629
throws IOException
2730
{

src/main/java/org/codehaus/plexus/archiver/zip/ZipResource.java

+3
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,8 @@
1515
import org.codehaus.plexus.components.io.resources.ClosingInputStream;
1616
import org.codehaus.plexus.components.io.resources.PlexusIoResource;
1717

18+
import javax.annotation.Nonnull;
19+
1820
public class ZipResource extends AbstractPlexusIoResource
1921
implements ResourceAttributeSupplier
2022
{
@@ -72,6 +74,7 @@ public URL getURL()
7274
return null;
7375
}
7476

77+
@Nonnull
7578
public InputStream getContents()
7679
throws IOException
7780
{

src/test/java/org/codehaus/plexus/archiver/jar/ManifestTest.java

-1
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@
2121
import java.io.IOException;
2222
import java.io.PrintWriter;
2323
import java.io.StringWriter;
24-
import java.util.Enumeration;
2524
import java.util.jar.Attributes;
2625
import org.codehaus.plexus.PlexusTestCase;
2726

0 commit comments

Comments
 (0)