Skip to content

Commit 45ba8d7

Browse files
committed
Added Disqus comments, and synced with Josh's changes
1 parent 3b611f6 commit 45ba8d7

19 files changed

+92
-6
lines changed

_includes/disqus.txt

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
<div id="disqus_thread"></div>
2+
<script type="text/javascript">
3+
4+
var disqus_shortname = 'scala-lang'; // required: replace example with your forum shortname
5+
6+
(function() {
7+
var dsq = document.createElement('script'); dsq.type = 'text/javascript'; dsq.async = true;
8+
dsq.src = 'http://' + disqus_shortname + '.disqus.com/embed.js';
9+
(document.getElementsByTagName('head')[0] || document.getElementsByTagName('body')[0]).appendChild(dsq);
10+
})();
11+
</script>

_includes/sips-topbar.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
<ul class="nav">
88
<li><a href="{{ site.baseurl }}/sips/sip-submission.html">Submitting a new SIP</a></li>
99
<li><a href="{{ site.baseurl }}/sips/sip-list.html">SIP List</a></li>
10-
<li><a href="{{ site.baseurl }}/sips/sip-tutorial.html">Writing a SIP Tutorial</a></li>
10+
<li><a href="{{ site.baseurl }}/sips/sip-tutorial.html">How to Write a SIP</a></li>
1111
</ul>
1212
</div>
1313
</div>

_layouts/default.html

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,8 @@
88
{% endif %}
99
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8"/>
1010

11+
<link rel="icon" type="image/png" href="{{ site.baseurl }}/favicon.ico">
12+
1113
<!-- Bootstrap CSS -->
1214
<link rel="stylesheet" href="{{ site.baseurl }}/stylesheets/bootstrap.css" type="text/css" />
1315

@@ -52,6 +54,7 @@ <h1>{{ site.title }}</h1>
5254
{% if page.title %}<h1>{{ page.title }}</h1>{% endif %}
5355
<div class="span12">
5456
{{ content }}
57+
{% if page.type == 'sip' %}{% include disqus.txt %}{% endif %}
5558
</div>
5659
{% if page.type == 'sip' %}
5760
<div class="span4">
Binary file not shown.
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
---
2+
layout: default
3+
type: sip
4+
title: SID-2 Scala Compiler Phase and Plug-In Initialization for Scala 2.8
5+
---
6+
7+
This was an older SID that can be found [here](http://www.scala-lang.org/sid/2)
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
---
2+
layout: default
3+
type: sid
4+
title: SID-4 - Early Member Definitions
5+
---
6+
7+
This was an older SID that can be found [here](http://www.scala-lang.org/sid/4)
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
---
2+
layout: default
3+
type: sip
4+
title: SID-8 - Scala Swing Overview
5+
---
6+
7+
This was an older SID that can be found [here](http://www.scala-lang.org/sid/8)
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
---
2+
layout: default
3+
type: sip
4+
title: SID-1 Named and Default Arguments
5+
---
6+
7+
This was an older SID that can be found [here](http://www.scala-lang.org/sid/1)
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
---
2+
layout: default
3+
type: sip
4+
title: SID-7 - Scala 2.8 Arrays
5+
---
6+
7+
This was an older SID that can be found [here](http://www.scala-lang.org/sid/7)
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
---
2+
layout: default
3+
type: sip
4+
title: SID-5 - Internals of Scala Annotations
5+
---
6+
7+
This was an older SID that can be found [here](http://www.scala-lang.org/sid/5)
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
---
2+
layout: default
3+
type: sip
4+
title: SID-9 - Scala Specialization
5+
---
6+
7+
This was an older SID that can be found [here](http://www.scala-lang.org/sid/9)
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
---
2+
layout: default
3+
type: sip
4+
title: SID-10 - Storage of pickled Scala signatures in class files
5+
---
6+
7+
This was an older SID that can be found [here](http://www.scala-lang.org/sid/10)
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
---
2+
layout: default
3+
type: sip
4+
title: SID-3 - New Collection classes
5+
---
6+
7+
This was an older SID that can be found [here](http://www.scala-lang.org/sid/3)

sips/index.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,4 +9,6 @@ title: Scala Improvement Process
99

1010
This is the landing page for the Scala Improvement Process.
1111

12+
This process has been changed since the old SID (Scala Improvement Document) days, however the old completed SID documents are available in the [completed section of the SIP list](sip-list.html).
13+
1214

sips/pending/_posts/2011-10-13-string-interpolation.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
---
22
layout: default
33
type: sip
4-
title: String Interpolation
4+
title: SIP-11 String Interpolation
55
---
66
### Martin Odersky ###
77

sips/pending/_posts/2011-10-13-uncluttering-control.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
---
22
layout: default
33
type: sip
4-
title: Uncluttering Scala’s syntax for control structures.
4+
title: SIP-12 Uncluttering Scala’s syntax for control structures.
55
---
66

77
__Motivation__: The more Scala code I write the more I get tripped up by the need to write conditions in if-then-else expressions and other control constructs in parentheses. I normally would not advocate syntax changes at this level, except that this has been the single syntax decision that feels worse for me the longer I use it.

sips/sip-list.md

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,26 @@
11
---
22
layout: default
33
type: sip
4-
title: Completed SIP list
4+
title: List of SIPs
55
---
66

7+
### Draft SIPs ###
8+
<ul class="post-list">
9+
{% for post in site.categories.draft %}
10+
<li><a href="{{ site.baseurl }}{{ post.url }}">{{ post.title }}</a> <span class="date">( {{ post.date | date: "%b %Y" }} )</span></li>
11+
{% endfor %}
12+
</ul>
13+
714
### Completed SIPs ###
815
<ul class="post-list">
916
{% for post in site.categories.completed %}
10-
<li><a href="/scala-docs/sips/{{ post.url }}">{{ post.title }}</a> <span class="date">( {{ post.date | date: "%b %Y" }} )</span></li>
17+
<li><a href="{{ site.baseurl }}{{ post.url }}">{{ post.title }}</a> <span class="date">( {{ post.date | date: "%b %Y" }} )</span></li>
1118
{% endfor %}
1219
</ul>
1320

1421
### Rejected SIPs ###
1522
<ul class="post-list">
1623
{% for post in site.categories.rejected %}
17-
<li><a href="/scala-docs/sips/{{ post.url }}">{{ post.title }}</a> <span class="date">( {{ post.date | date: "%b %Y" }} )</span></li>
24+
<li><a href="{{ site.baseurl }}{{ post.url }}">{{ post.title }}</a> <span class="date">( {{ post.date | date: "%b %Y" }} )</span></li>
1825
{% endfor %}
1926
</ul>

0 commit comments

Comments
 (0)