Skip to content

Commit 6e5c5e7

Browse files
committed
Merge branch 'develop' of https://github.com/cocos2d/cocos2d-js into develop
2 parents db95f5c + 0ce1d72 commit 6e5c5e7

File tree

2 files changed

+44
-33
lines changed

2 files changed

+44
-33
lines changed

frameworks/js-bindings/bindings/auto/jsb_cocos2dx_spine_auto.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
#include "jsb_cocos2dx_spine_auto.hpp"
22
#include "cocos2d_specifics.hpp"
33
#include "spine-cocos2dx.h"
4+
#include "jsb_cocos2dx_spine_manual.h"
45

56
template<class T>
67
static bool dummy_constructor(JSContext *cx, uint32_t argc, jsval *vp) {

frameworks/js-bindings/bindings/manual/cocos2d_specifics.cpp

Lines changed: 43 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -624,44 +624,54 @@ bool js_cocos2dx_CCMenuItemToggle_create(JSContext *cx, uint32_t argc, jsval *vp
624624
return false;
625625
}
626626

627-
// "setCallback" in JS
628-
// item.setCallback( callback_fn, [this]);
629-
template<class T>
630-
bool js_cocos2dx_setCallback(JSContext *cx, uint32_t argc, jsval *vp)
627+
bool js_cocos2dx_MenuItem_setCallback(JSContext *cx, uint32_t argc, jsval *vp)
631628
{
632-
if(argc == 1 || argc == 2)
633-
{
634-
jsval *argv = JS_ARGV(cx, vp);
635-
JSObject *obj = JS_THIS_OBJECT(cx, vp);
636-
jsval jsThis = JSVAL_VOID;
637-
jsval jsFunc = argv[0];
638-
639-
if (jsFunc.isUndefined())
640-
{
641-
JS_ReportError(cx, "The callback function is undefined.");
642-
return false;
643-
}
644-
645-
if (argc == 2)
646-
{
647-
jsThis = argv[1];
648-
}
649-
650-
js_proxy_t *proxy = jsb_get_js_proxy(obj);
651-
T* item = (T*)(proxy ? proxy->ptr : NULL);
652-
TEST_NATIVE_OBJECT(cx, item)
653-
bind_menu_item(cx, item, jsFunc, jsThis);
629+
jsval *argv = JS_ARGV(cx, vp);
630+
bool ok = true;
631+
JSObject *obj = JS_THIS_OBJECT(cx, vp);
632+
js_proxy_t *proxy = jsb_get_js_proxy(obj);
633+
cocos2d::MenuItem* cobj = (cocos2d::MenuItem *)(proxy ? proxy->ptr : NULL);
634+
JSB_PRECONDITION2( cobj, cx, false, "js_cocos2dx_MenuItem_setCallback : Invalid Native Object");
635+
if (argc == 1 || argc == 2) {
636+
std::function<void (cocos2d::Ref *)> arg0;
637+
do {
638+
if(JS_TypeOfValue(cx, argv[0]) == JSTYPE_FUNCTION)
639+
{
640+
std::shared_ptr<JSFunctionWrapper> func(new JSFunctionWrapper(cx, JS_THIS_OBJECT(cx, vp), argv[0]));
641+
auto lambda = [=](cocos2d::Ref* larg0) -> void {
642+
jsval largv[1];
643+
do {
644+
if (larg0) {
645+
js_proxy_t *jsProxy = js_get_or_create_proxy<cocos2d::Ref>(cx, (cocos2d::Ref*)larg0);
646+
largv[0] = OBJECT_TO_JSVAL(jsProxy->obj);
647+
} else {
648+
largv[0] = JSVAL_NULL;
649+
}
650+
} while (0);
651+
jsval rval;
652+
bool ok = func->invoke(1, &largv[0], rval);
653+
if (!ok && JS_IsExceptionPending(cx)) {
654+
JS_ReportPendingException(cx);
655+
}
656+
};
657+
arg0 = lambda;
658+
}
659+
else
660+
{
661+
arg0 = nullptr;
662+
}
663+
} while(0)
664+
;
665+
JSB_PRECONDITION2(ok, cx, false, "js_cocos2dx_MenuItem_setCallback : Error processing arguments");
666+
cobj->setCallback(arg0);
667+
JS_SET_RVAL(cx, vp, JSVAL_VOID);
654668
return true;
655669
}
656-
JS_ReportError(cx, "wrong number of arguments: %d, was expecting %d or %d", argc, 1, 2);
657-
return false;
658-
}
659670

660-
bool js_cocos2dx_CCMenuItem_setCallback(JSContext *cx, uint32_t argc, jsval *vp) {
661-
return js_cocos2dx_setCallback<cocos2d::MenuItem>(cx, argc, vp);
671+
JS_ReportError(cx, "js_cocos2dx_MenuItem_setCallback : wrong number of arguments: %d, was expecting %d", argc, 1);
672+
return false;
662673
}
663674

664-
665675
bool js_cocos2dx_CCAnimation_create(JSContext *cx, uint32_t argc, jsval *vp)
666676
{
667677
bool ok = true;
@@ -4869,7 +4879,7 @@ void register_cocos2dx_js_extensions(JSContext* cx, JSObject* global)
48694879
JS_DefineFunction(cx, jsb_cocos2d_Animation_prototype, "release", js_cocos2dx_release, 0, JSPROP_ENUMERATE | JSPROP_PERMANENT);
48704880
JS_DefineFunction(cx, jsb_cocos2d_SpriteFrame_prototype, "retain", js_cocos2dx_retain, 0, JSPROP_ENUMERATE | JSPROP_PERMANENT);
48714881
JS_DefineFunction(cx, jsb_cocos2d_SpriteFrame_prototype, "release", js_cocos2dx_release, 0, JSPROP_ENUMERATE | JSPROP_PERMANENT);
4872-
JS_DefineFunction(cx, jsb_cocos2d_MenuItem_prototype, "setCallback", js_cocos2dx_CCMenuItem_setCallback, 2, JSPROP_ENUMERATE | JSPROP_PERMANENT);
4882+
JS_DefineFunction(cx, jsb_cocos2d_MenuItem_prototype, "setCallback", js_cocos2dx_MenuItem_setCallback, 2, JSPROP_ENUMERATE | JSPROP_PERMANENT);
48734883
JS_DefineFunction(cx, jsb_cocos2d_TMXLayer_prototype, "getTileFlagsAt", js_cocos2dx_CCTMXLayer_tileFlagsAt, 2, JSPROP_ENUMERATE | JSPROP_PERMANENT);
48744884
JS_DefineFunction(cx, jsb_cocos2d_TMXLayer_prototype, "getTiles", js_cocos2dx_CCTMXLayer_getTiles, 0, JSPROP_ENUMERATE | JSPROP_PERMANENT);
48754885

0 commit comments

Comments
 (0)