Skip to content

Update web spine to 3.6.39 #3551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 16, 2018

Conversation

drelaptop
Copy link
Contributor

No description provided.

@drelaptop
Copy link
Contributor Author

drelaptop commented Apr 12, 2018

Update spine.js to 3.6.39, and tested on Chrome and Safari, all the spine test cases hold the same behavior with Cocos2d-x 3.16.

Except, fix canvas draw point scale error, the wrong effect on Cocos2d-x 3.16:

another-fix

Attention, the SpineTestPerformance shows the spine performance is low, when run on Chrome and Safari, less than 5 goblins can existed at the same time. or it's a buffer length bug?

@dalste
Copy link

dalste commented Apr 12, 2018

have you guys come across this bug since 3.16 ? - apparently also present in tests when goblins amount to 5. Something to do with new batching code?

http://discuss.cocos2d-x.org/t/spine-web-runtime-cocos2dxjs-3-16-offscreen-for-webgl-000002366a2544e0-gl-error-gl-invalid-operation-gldrawelements-range-out-of-bounds-for-buffer/42133

@drelaptop
Copy link
Contributor Author

drelaptop commented Apr 13, 2018

@dalste refer to this commit adeefef to fix, only 2 lines modified

tested on Chrome and Safari, all works well.

spine-test3

@drelaptop drelaptop changed the title [in-progress] Update web spine to 3.6.39 Update web spine to 3.6.39 Apr 13, 2018
@drelaptop
Copy link
Contributor Author

@pandamicro review and merge please

@dalste
Copy link

dalste commented Apr 16, 2018

@drelaptop I'm still getting that same error (GL ERROR :GL_INVALID_OPERATION : glDrawElements: range out of bounds for buffer) with one of my spine files, the same file works fine on the native run times.

I can send you guys the file via pm/ email to test if you like, I would need to blur the atlases though to protect copyright.

@drelaptop
Copy link
Contributor Author

@dalste thanks for feedback, I will try to solve it if I am free, please email the spine files to [email protected]

@Yehsam23
Copy link

@drelaptop
We got same error, do you receive @dalste test? or any update?

Thanks

@kuldeepteekas123
Copy link

kuldeepteekas123 commented Dec 19, 2018

i am working with cocos3.17 JS version, this problem still persist. Whenever i am trying to create more than 5 spines i get
"GL ERROR :GL_INVALID_OPERATION : glDrawElements: range out of bounds for buffer" error.

While those spines are working fine on Native platforms and in Cocos2dx C++.
I tried backtracing the issue, tried the same on cocos version 3.15,14,12 but no success .

I am working on Spine runtime version 3.6.39
Could anyone update me how to resolve this issue for web version for Spines ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants