BinaryLoader 设置 xhr.responseType="arraybuffer"，使用 xhr.response 响应数据 #3512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, it was due to history reason, when we created cocos2d-html5, there was no arraybuffer response type yet. Thanks for the contribution, I will merge it in my PR Because I changed the commit name to English, don't worry, your contribution is still noted in git. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XMLHttpRequest支持响应数据ArrayBuffer类型，这里之前没有使用这个类型而是使用responseText然后再转换为ArrayBuffer是有什么历史原因吗？如果没有特殊原因，直接指定responseType为"arraybuffer"然后使用response更好。