Simpler CCLabelTTF.getContentSize() fix #3407
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…na mode" This reverts commit 9b077f8.
|
OK, I see what's wrong with this: _contentSize is just used everywhere instead of getContentSize(), so fixing it there has little use... |
pandamicro
pushed a commit
to pandamicro/cocos2d-html5
that referenced
this pull request
Dec 6, 2016
|
Sorry for the delay, indeed there was some problem with the content size, especially when we want to get the bounding box, the result is always half the size. I have merged you commit and fixed some issue in this commit: pandamicro@956b26e Please take a look, I will first merge #3403, then send another pull request which include your pr and other improvements. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #3306 (review) for previous attempt.