Skip to content

Commit 8071229

Browse files
committed
Merge pull request #2802 from dingpinglv/Iss_LabelTTF
Fixed a bug of cc.LabelTTF that its enableShadow doesn't work.
2 parents d47f061 + c8af0a9 commit 8071229

File tree

2 files changed

+11
-8
lines changed

2 files changed

+11
-8
lines changed

cocos2d/core/labelttf/CCLabelTTFCanvasRenderCmd.js

+8-6
Original file line numberDiff line numberDiff line change
@@ -412,12 +412,14 @@ cc.LabelTTF._firsrEnglish = /^[a-zA-Z0-9ÄÖÜäöüßéèçàùêâîôû]/;
412412
var locDisplayColor = this._displayedColor, node = this._node,
413413
locShadowColor = node._shadowColor || this._displayedColor;
414414
var locStrokeColor = node._strokeColor, locFontFillColor = node._textFillColor;
415-
416-
this._shadowColorStr = "rgba(" + (0 | (locShadowColor.r * 0.5)) + "," + (0 | (locShadowColor.g * 0.5)) + "," + (0 | (locShadowColor.b * 0.5)) + "," + node._shadowOpacity + ")";
417-
this._fillColorStr = "rgba(" + (0 | (locDisplayColor.r / 255 * locFontFillColor.r)) + "," + (0 | (locDisplayColor.g / 255 * locFontFillColor.g)) + ","
418-
+ (0 | (locDisplayColor.b / 255 * locFontFillColor.b)) + ", 1)"; //use globalOpacity + locDisplayedOpacity / 255 + ")";
419-
this._strokeColorStr = "rgba(" + (0 | (locDisplayColor.r / 255 * locStrokeColor.r)) + "," + (0 | (locDisplayColor.g / 255 * locStrokeColor.g)) + ","
420-
+ (0 | (locDisplayColor.b / 255 * locStrokeColor.b)) + ", 1)"; //use globalOpacity + locDisplayedOpacity / 255 + ")";
415+
var dr = locDisplayColor.r / 255, dg = locDisplayColor.g / 255, db = locDisplayColor.b / 255;
416+
417+
this._shadowColorStr = "rgba(" + (0 | (dr * locShadowColor.r)) + "," + (0 | ( dg * locShadowColor.g)) + ","
418+
+ (0 | (db * locShadowColor.b)) + "," + node._shadowOpacity + ")";
419+
this._fillColorStr = "rgba(" + (0 | (dr * locFontFillColor.r)) + "," + (0 | (dg * locFontFillColor.g)) + ","
420+
+ (0 | (db * locFontFillColor.b)) + ", 1)";
421+
this._strokeColorStr = "rgba(" + (0 | (dr * locStrokeColor.r)) + "," + (0 | (dg * locStrokeColor.g)) + ","
422+
+ (0 | (db * locStrokeColor.b)) + ", 1)";
421423
};
422424

423425
proto._updateColor = function(){

cocos2d/core/labelttf/CCLabelTTFWebGLRenderCmd.js

+3-2
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,9 @@
3737
proto._setColorsString = function () {
3838
this.setDirtyFlag(cc.Node._dirtyFlags.textDirty);
3939
var node = this._node;
40-
var locStrokeColor = node._strokeColor, locFontFillColor = node._textFillColor;
41-
this._shadowColorStr = "rgba(128,128,128," + node._shadowOpacity + ")";
40+
var locStrokeColor = node._strokeColor, locFontFillColor = node._textFillColor,
41+
locShadowColor = node._shadowColor || this._displayedColor;
42+
this._shadowColorStr = "rgba(" + (0 | locShadowColor.r) + "," + (0 | locShadowColor.g) + "," + (0 | locShadowColor.b) + "," + node._shadowOpacity + ")";
4243
this._fillColorStr = "rgba(" + (0 | locFontFillColor.r) + "," + (0 | locFontFillColor.g) + "," + (0 | locFontFillColor.b) + ", 1)";
4344
this._strokeColorStr = "rgba(" + (0 | locStrokeColor.r) + "," + (0 | locStrokeColor.g) + "," + (0 | locStrokeColor.b) + ", 1)";
4445
};

0 commit comments

Comments
 (0)