Skip to content

Commit 4dfad9f

Browse files
committed
Fix a bunch of issues
1 parent fb2a31b commit 4dfad9f

File tree

7 files changed

+17
-14
lines changed

7 files changed

+17
-14
lines changed

cocos2d/core/CCDirector.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -183,7 +183,7 @@ cc.Director = cc.Class.extend(/** @lends cc.Director# */{
183183
convertToGL: function (uiPoint) {
184184
var docElem = document.documentElement;
185185
var view = cc.view;
186-
var box = element.getBoundingClientRect();
186+
var box = docElem.getBoundingClientRect();
187187
box.left += window.pageXOffset - docElem.clientLeft;
188188
box.top += window.pageYOffset - docElem.clientTop;
189189
var x = view._devicePixelRatio * (uiPoint.x - box.left);
@@ -202,7 +202,7 @@ cc.Director = cc.Class.extend(/** @lends cc.Director# */{
202202
convertToUI: function (glPoint) {
203203
var docElem = document.documentElement;
204204
var view = cc.view;
205-
var box = element.getBoundingClientRect();
205+
var box = docElem.getBoundingClientRect();
206206
box.left += window.pageXOffset - docElem.clientLeft;
207207
box.top += window.pageYOffset - docElem.clientTop;
208208
var uiPoint = {x: 0, y: 0};

cocos2d/core/base-nodes/CCNode.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -2015,7 +2015,7 @@ cc.Node = cc.Class.extend(/** @lends cc.Node# */{
20152015
updateTransform: function () {
20162016
var children = this._children, node;
20172017
for (var i = 0; i < children.length; i++) {
2018-
varnode = children[i];
2018+
var node = children[i];
20192019
if (node)
20202020
node.updateTransform();
20212021
}

cocos2d/core/layers/CCLayer.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -247,7 +247,7 @@ cc.LayerColor = cc.Layer.extend(/** @lends cc.LayerColor# */{
247247
return true;
248248
},
249249

250-
visit: function () {
250+
visit: function (parent) {
251251
// quick return if not visible
252252
if (!this._visible)
253253
return;

cocos2d/core/scenes/CCLoaderScene.js

+2-1
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@
3333
cc.LoaderScene = cc.Scene.extend({
3434
_interval : null,
3535
_label : null,
36+
_logo : null,
3637
_className:"LoaderScene",
3738
cb: null,
3839
target: null,
@@ -132,7 +133,7 @@ cc.LoaderScene = cc.Scene.extend({
132133
this._renderCmd.setDirtyFlag(cc.Node._dirtyFlags.transformDirty);
133134
this._bgLayer._renderCmd.setDirtyFlag(cc.Node._dirtyFlags.transformDirty);
134135
this._label._renderCmd.setDirtyFlag(cc.Node._dirtyFlags.transformDirty);
135-
this._logo._renderCmd.setDirtyFlag(cc.Node._dirtyFlags.transformDirty);
136+
this._logo && this._logo._renderCmd.setDirtyFlag(cc.Node._dirtyFlags.transformDirty);
136137
}
137138
});
138139
/**

cocos2d/core/sprites/CCSpriteFrameCache.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,7 @@ cc.spriteFrameCache = /** @lends cc.spriteFrameCache# */{
169169
var frame = frames[key];
170170
var spriteFrame = spriteFrames[key];
171171
if (!spriteFrame) {
172-
spriteFrame = new cc.SpriteFrame(texture, frame.rect, frame.rotated, frame.offset, frame.size);
172+
spriteFrame = new cc.SpriteFrame(texture, cc.rect(frame.rect), frame.rotated, frame.offset, frame.size);
173173
var aliases = frame.aliases;
174174
if (aliases) {//set aliases
175175
for (var i = 0, li = aliases.length; i < li; i++) {

cocos2d/core/sprites/CCSpriteWebGLRenderCmd.js

+6-4
Original file line numberDiff line numberDiff line change
@@ -235,10 +235,12 @@
235235
node._texture = texture;
236236

237237
// Update texture rect and blend func
238-
var texSize = texture._contentSize;
239-
var rect = cc.rect(0, 0, texSize.width, texSize.height);
240-
node.setTextureRect(rect);
241-
this._updateBlendFunc();
238+
if (texture) {
239+
var texSize = texture._contentSize;
240+
var rect = cc.rect(0, 0, texSize.width, texSize.height);
241+
node.setTextureRect(rect);
242+
this._updateBlendFunc();
243+
}
242244

243245
if (node._textureLoaded) {
244246
// Force refresh the render command list

extensions/cocostudio/loader/parsers/timelineParser-2.x.js

+4-4
Original file line numberDiff line numberDiff line change
@@ -1078,18 +1078,18 @@
10781078
* @returns {ccui.TextBMFont}
10791079
*/
10801080
parser.initTextBMFont = function (json, resourcePath) {
1081-
10821081
var widget = new ccui.TextBMFont();
10831082
this.widgetAttributes(widget, json);
10841083

1085-
var text = json["LabelText"];
1086-
widget.setString(text);
1087-
10881084
loadTexture(json["LabelBMFontFile_CNB"], resourcePath, function (path, type) {
10891085
if (!cc.loader.getRes(path))
10901086
cc.log("%s need to be pre loaded", path);
10911087
widget.setFntFile(path);
10921088
});
1089+
1090+
var text = json["LabelText"];
1091+
widget.setString(text);
1092+
10931093
widget.ignoreContentAdaptWithSize(true);
10941094
return widget;
10951095
};

0 commit comments

Comments
 (0)