Skip to content

Commit 372ea5a

Browse files
authored
Merge pull request #3447 from zilongshanren/improve-ui-text
improve uiText, simplify code and add auto resize height option
2 parents cc08286 + ed89551 commit 372ea5a

File tree

1 file changed

+6
-20
lines changed

1 file changed

+6
-20
lines changed

extensions/ccui/uiwidgets/UIText.js

+6-20
Original file line numberDiff line numberDiff line change
@@ -99,15 +99,12 @@ ccui.Text = ccui.Widget.extend(/** @lends ccui.Text# */{
9999
*/
100100
setString: function (text) {
101101
if(text === this._labelRenderer.getString()) return;
102+
this._setString(text);
102103

103-
this._labelRenderer.setString(text);
104104
this._updateContentSizeWithTextureSize(this._labelRenderer.getContentSize());
105-
this._labelRendererAdaptDirty = true;
106105
},
107106

108107
_setString: function (text) {
109-
if(text === this._labelRenderer.getString()) return;
110-
111108
this._labelRenderer.setString(text);
112109
this._labelRendererAdaptDirty = true;
113110
},
@@ -143,10 +140,8 @@ ccui.Text = ccui.Widget.extend(/** @lends ccui.Text# */{
143140
* @param {Number} size
144141
*/
145142
setFontSize: function (size) {
146-
this._labelRenderer.setFontSize(size);
147-
this._fontSize = size;
143+
this._setFontSize(size);
148144
this._updateContentSizeWithTextureSize(this._labelRenderer.getContentSize());
149-
this._labelRendererAdaptDirty = true;
150145
},
151146

152147
_setFontSize: function (size) {
@@ -168,10 +163,8 @@ ccui.Text = ccui.Widget.extend(/** @lends ccui.Text# */{
168163
* @return {String} name
169164
*/
170165
setFontName: function (name) {
171-
this._fontName = name;
172-
this._labelRenderer.setFontName(name);
166+
this._setFontName(name);
173167
this._updateContentSizeWithTextureSize(this._labelRenderer.getContentSize());
174-
this._labelRendererAdaptDirty = true;
175168
},
176169

177170
_setFontName: function (name) {
@@ -218,12 +211,8 @@ ccui.Text = ccui.Widget.extend(/** @lends ccui.Text# */{
218211
* @param {cc.Size} size
219212
*/
220213
setTextAreaSize: function (size) {
221-
this._labelRenderer.setDimensions(size);
222-
if (!this._ignoreSize) {
223-
this._customSize = size;
224-
}
214+
this._setTextAreaSize(size);
225215
this._updateContentSizeWithTextureSize(this._labelRenderer.getContentSize());
226-
this._labelRendererAdaptDirty = true;
227216
},
228217

229218
_setTextAreaSize: function (size) {
@@ -247,9 +236,8 @@ ccui.Text = ccui.Widget.extend(/** @lends ccui.Text# */{
247236
* @param {cc.TEXT_ALIGNMENT_LEFT|cc.TEXT_ALIGNMENT_CENTER|cc.TEXT_ALIGNMENT_RIGHT} alignment Horizontal Alignment
248237
*/
249238
setTextHorizontalAlignment: function (alignment) {
250-
this._labelRenderer.setHorizontalAlignment(alignment);
239+
this._setTextHorizontalAlignment(alignment);
251240
this._updateContentSizeWithTextureSize(this._labelRenderer.getContentSize());
252-
this._labelRendererAdaptDirty = true;
253241
},
254242

255243

@@ -271,9 +259,8 @@ ccui.Text = ccui.Widget.extend(/** @lends ccui.Text# */{
271259
* @param {cc.VERTICAL_TEXT_ALIGNMENT_TOP|cc.VERTICAL_TEXT_ALIGNMENT_CENTER|cc.VERTICAL_TEXT_ALIGNMENT_BOTTOM} alignment
272260
*/
273261
setTextVerticalAlignment: function (alignment) {
274-
this._labelRenderer.setVerticalAlignment(alignment);
262+
this._setTextVerticalAlignment(alignment);
275263
this._updateContentSizeWithTextureSize(this._labelRenderer.getContentSize());
276-
this._labelRendererAdaptDirty = true;
277264
},
278265

279266
_setTextVerticalAlignment: function (alignment) {
@@ -364,7 +351,6 @@ ccui.Text = ccui.Widget.extend(/** @lends ccui.Text# */{
364351
_labelScaleChangedWithSize: function () {
365352
var locContentSize = this._contentSize;
366353
if (this._ignoreSize) {
367-
this._labelRenderer.setDimensions(0, 0);
368354
this._labelRenderer.setScale(1.0);
369355
this._normalScaleValueX = this._normalScaleValueY = 1;
370356
} else {

0 commit comments

Comments
 (0)