Skip to content

Commit 368ba1a

Browse files
authored
Resolve old FIXME comments (rust-lang#1364)
1 parent 6d0d7ef commit 368ba1a

File tree

2 files changed

+3
-6
lines changed

2 files changed

+3
-6
lines changed

crates/core_arch/src/wasm32/simd128.rs

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2349,10 +2349,6 @@ pub use i8x16_all_true as u8x16_all_true;
23492349
#[doc(alias("i8x16.bitmask"))]
23502350
#[stable(feature = "wasm_simd", since = "1.54.0")]
23512351
pub fn i8x16_bitmask(a: v128) -> u16 {
2352-
// FIXME(https://bugs.llvm.org/show_bug.cgi?id=50507) - this produces an
2353-
// extraneous `i32.and` instruction against a mask of 65535 when converting
2354-
// from the native intrinsic's i32 return value to our desired u16. This
2355-
// shouldn't be necessary, though, but requires upstream LLVM changes.
23562352
unsafe { llvm_bitmask_i8x16(a.as_i8x16()) as u16 }
23572353
}
23582354

@@ -3460,7 +3456,7 @@ pub use i32x4_extmul_high_u16x8 as u32x4_extmul_high_u16x8;
34603456

34613457
/// Lane-wise wrapping absolute value.
34623458
#[inline]
3463-
// #[cfg_attr(test, assert_instr(i64x2.abs))] // FIXME llvm
3459+
#[cfg_attr(test, assert_instr(i64x2.abs))]
34643460
#[target_feature(enable = "simd128")]
34653461
#[doc(alias("i64x2.abs"))]
34663462
#[stable(feature = "wasm_simd", since = "1.54.0")]

crates/core_arch/src/x86/avx2.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -527,7 +527,8 @@ pub unsafe fn _mm256_broadcastd_epi32(a: __m128i) -> __m256i {
527527
/// [Intel's documentation](https://software.intel.com/sites/landingpage/IntrinsicsGuide/#text=_mm_broadcastq_epi64)
528528
#[inline]
529529
#[target_feature(enable = "avx2")]
530-
// FIXME: https://github.com/rust-lang/stdarch/issues/791
530+
// Emits `vmovddup` instead of `vpbroadcastq`
531+
// See https://github.com/rust-lang/stdarch/issues/791
531532
#[cfg_attr(test, assert_instr(vmovddup))]
532533
#[stable(feature = "simd_x86", since = "1.27.0")]
533534
pub unsafe fn _mm_broadcastq_epi64(a: __m128i) -> __m128i {

0 commit comments

Comments
 (0)