fix tests (sd lag should only be 0)

Author: dsweber2

DESCRIPTION

@@ -30,7 +30,8 @@ Imports:
     slider,
     targets,
     tibble,
-    tidyr
+    tidyr,
+    zeallot
 Suggests:
     ggplot2,
     knitr,

R/data_validation.R

@@ -56,7 +56,7 @@ perform_sanity_checks <- function(epi_data,
 #' @export
 confirm_sufficient_data <- function(epi_data, ahead, args_input, buffer = 9) {
   if (!is.null(args_input$lags)) {
-    lag_max <- max(args_input$lags)
+    lag_max <- max(unlist(args_input$lags))
   } else {
     lag_max <- 14 # default value of 2 weeks
   }

R/forecaster_smoothed_scaled.R

@@ -5,6 +5,8 @@
 #'   /target/ it still uses the raw value (this captures some of the noise).  It
 #'   also uses a rolling standard deviation as an auxillary signal, window of
 #'   withd `sd_width`, which by default is 28 days.
+#' If you are using `sd_width`, you should restrict the lags on the `sd` to only
+#'   include `0`, so set your lags to be e.g. `list(c(0,7,14), c(0))`.
 #' @param epi_data the actual data used
 #' @param outcome the name of the target variable
 #' @param extra_sources the name of any extra columns to use. This list could be

tests/testthat/test-forecasters-data.R

@@ -7,7 +7,7 @@ forecasters <- tibble::tribble(
   scaled_pop, list(1, TRUE), list("ahead", "pop_scaling"), "scaled_pop",
   scaled_pop, list(1, FALSE), list("ahead", "pop_scaling"), "scaled_pop",
   flatline_fc, list(1), list("ahead"), "flatline_fc",
-  smoothed_scaled, list(1), list("ahead"), "smoothed_scaled"
+  smoothed_scaled, list(1, list(c(0,7,14), c(0))), list("ahead", "lags"), "smoothed_scaled"
 )
 expects_nonequal <- c("scaled_pop", "smoothed_scaled")
 synth_mean <- 25