Skip to content

Don't filter by time_value in as_of #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
brookslogan opened this issue Jun 2, 2022 · 1 comment · Fixed by #129
Closed

Don't filter by time_value in as_of #90

brookslogan opened this issue Jun 2, 2022 · 1 comment · Fixed by #129
Assignees
@rachlobay
Labels
op-semantics Operational semantics; many potentially breaking changes here P1 medium priority

Comments

@brookslogan
Copy link
Contributor

The current as_of includes a time filter relative to the version value. This prevents us from using as_of when storing forecasts in an epi_archive.
@brookslogan brookslogan added op-semantics Operational semantics; many potentially breaking changes here P1 medium priority labels Jun 2, 2022
@rachlobay rachlobay self-assigned this Jun 11, 2022
@brookslogan
Copy link
Contributor Author

brookslogan commented Jun 13, 2022 •
edited
Loading

Fixing this will likely break arx_forecaster due to a bug there. I'm writing up some comments and then will open an issue on that other bug. The other bug will likely need to be resolved first and will block this one. Nevermind, while arx_forecaster/get_predictions is already buggy, and fixing the current issue would likely exacerbate this bug if we were putting in point forecasts as an AR covariate, I don't think this needs to wait for that other issue to be resolved.

@brookslogan brookslogan mentioned this issue Jun 21, 2022
Closed
9 tasks
@rachlobay rachlobay mentioned this issue Jun 28, 2022
Merged
@rachlobay rachlobay linked a pull request Jun 28, 2022 that will close this issue
Removed time filter in relation to version in as_of #129
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rachlobay rachlobay

Labels
op-semantics Operational semantics; many potentially breaking changes here P1 medium priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removed time filter in relation to version in as_of cmu-delphi/epiprocess
2 participants
@brookslogan @rachlobay