-
Notifications
You must be signed in to change notification settings - Fork 8
Consider storing vignette input data in package #72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Another factor to consider here: repository and package size. We shouldn't store massive data objects here, to keep git operations responsive and fully-featureful (merge operations can degrade in the presence of massive data objects), and to keep clones and installs quick. (Already the repository is 35MB, not instant to clone.) |
I suspect that must be largely the All that said, I'm going to try to enforce the "no data bigger than 1MB" rule. |
I would also guess that's the case. With the current I'm just skimming here [... I guess that was the wrong place, maybe here is more relevant, but it looks like |
I think we may need to keep some of the docs for basic |
@dajmcdon raised the possibility of replacing API queries in the vignettes and examples to internal data, in order to speed up vignette building and help with CI; the fetching code could be left in with an
eval=FALSE
. The drawback is potential license-related questions: what LICENSE do we assign the package if it mixes MIT-licensed code and CC/other-licensed data?The text was updated successfully, but these errors were encountered: