Skip to content

Use glmgen in growth rate function when ready #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ryantibs opened this issue Mar 10, 2022 · 0 comments · Fixed by #595
Closed

Use glmgen in growth rate function when ready #57

ryantibs opened this issue Mar 10, 2022 · 0 comments · Fixed by #595
Labels
blocked-by-external Can't/shouldn't proceed w/o external action or PRs --- check back periodically enhancement New feature or request P2 low priority

Comments

@ryantibs
Copy link
Member

When glmgen::trendfilter() is a bit more robust and battle-hardened (is that ever going to happen?), we should use it in the growth_rate() function for the trend filtering option, instead of genlasso::trendfilter().

The glmgen version is going to be much faster, and it would allow for arguments to be more directly passed, just like the smooth spline option (instead of the weird/custom argument handling we have now).

@ryantibs ryantibs added the enhancement New feature or request label Mar 10, 2022
@brookslogan brookslogan added P2 low priority blocked-by-external Can't/shouldn't proceed w/o external action or PRs --- check back periodically labels May 24, 2022
@dajmcdon dajmcdon mentioned this issue Jan 23, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked-by-external Can't/shouldn't proceed w/o external action or PRs --- check back periodically enhancement New feature or request P2 low priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants