Skip to content

select.epi_df falls back to tibble if geo_value or time_value are removed #505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dshemetov opened this issue Aug 8, 2024 · 2 comments · Fixed by #538
Closed

select.epi_df falls back to tibble if geo_value or time_value are removed #505

dshemetov opened this issue Aug 8, 2024 · 2 comments · Fixed by #538
Assignees

Comments

@dshemetov
Copy link
Contributor

dshemetov commented Aug 8, 2024

We should either document this explicitly or error.

r$> epiprocess::jhu_csse_daily_subset %>% select(cases)
# A tibble: 4,026 × 1
   cases
 * <dbl>
 1     6
 2     4
 3     6
 4    11
 5    10
 6    18
 7    26
 8    19
 9    23
10    22
# ℹ 4,016 more rows
# ℹ Use `print(n = ...)` to see more rows
@brookslogan
Copy link
Contributor

  • dplyr_extending says decaying is the way you should do it, at least.
  • And ideally this would mainly happen when the user doesn't need epi_dfness anymore anyway. One exception before was .x fed to a geo-grouped slide computation, but recent slide updates have moved to .keep = TRUE so .x will now be an epi_df there, too.

So seems like explicitly documenting might be the way to go.

@dshemetov dshemetov self-assigned this Oct 15, 2024
@dshemetov
Copy link
Contributor Author

Adding an example to the Getting Started page and in epi_df reference page in #538.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants