Skip to content

pkgdown on PRs appears to be deploying to dev #483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
brookslogan opened this issue Jul 17, 2024 · 2 comments
Closed

pkgdown on PRs appears to be deploying to dev #483

brookslogan opened this issue Jul 17, 2024 · 2 comments

Comments

@brookslogan
Copy link
Contributor

E.g., see this vignette which includes changes from this unmerged PR. (I thought we were using a setting to disable this deployment if it's a PR; maybe that logic isn't right or a breaking change has occurred.)

@brookslogan
Copy link
Contributor Author

Marking medium priority as this might lead to confusing docs; these might be limited to the dev site but we're also not merging to main very frequently yet.

@brookslogan
Copy link
Contributor Author

brookslogan commented Jul 17, 2024

Actually, these two both are the "old" version (with "nonseasonal" model) rather than the "new" version (with "reseasonal" name). Apparently I failed to build the PR branch docs with the new epiprocess; perhaps I needed to load_all() before build_site()? [This doesn't make sense; the text above is in the vignette source, not the package.] Anyway, doesn't appear to be a CI failure.

[Real issue was not realizing git checkout failed. Thought it wouldn't be possible without untracked local files, but forgot the PR branch was already checked out in a git worktree.]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant