-
Notifications
You must be signed in to change notification settings - Fork 8
Allow < 3 args in both epi_slide
and epix_slide
#478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
epi_slide
and epix_slide
epi_slide
and epix_slide
We might want to tackle this after we raise an error on Context: we originally inherited a >= 2-arg restriction from |
Huh, I started thinking about this and the logic seems a bit tricky. Like even leaving aside tidyeval and leaving aside functions that allow dots, we have these cases:
Writing this out, it seems sort of doable, though a bit fragile. I haven't thought through the dots case, but it seems hard to get a grasp on. |
We already attempted some of this logic in the warnings; they may provide some ideas. We constrained the arguments by position, not by name, so there was no searching through the argument names. We were a bit more trigger-happy there, but recent slide updates ( Some notes:
|
Forking off from #475 because it's a separate idea.
Looking at this warning and the code generating it a little more carefully
This is about what inputs the function should expect. I definitely don't think this should be an error, and we should probably just not pass those args to the function if it isn't expecting them. There are plenty of cases where you don't actually need to pass the keys or the ref_time_value, which came up in the discussion yesterday. Perhaps there are cases where that's actually an error, but I think we should probably trust the user to figure that out; it should be pretty obvious to them if they're actually trying to get the keys.
The text was updated successfully, but these errors were encountered: