Skip to content

Do we need as_tibble() to drop the class? #467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dajmcdon opened this issue Jun 19, 2024 · 0 comments · Fixed by #471
Closed

Do we need as_tibble() to drop the class? #467

dajmcdon opened this issue Jun 19, 2024 · 0 comments · Fixed by #471
Assignees
@brookslogan

Comments

@dajmcdon
Copy link
Contributor

epiprocess/R/methods-epi_df.R

Line 11 in 7fd2119

as_tibble.epi_df <- function(x, ...) {

  • This makes epipredict internals painful. I can see that someone may want this behaviour, but it means any time someone calls a function (from another package) that anywhere uses as_tibble(), it drops the class.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brookslogan brookslogan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Djm/as tibble attr cmu-delphi/epiprocess
2 participants
@dajmcdon @brookslogan