Skip to content

[PERF] Make new_epi_archive more unsafe and more efficient and use it in safe places #445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dshemetov opened this issue May 1, 2024 · 1 comment · Fixed by #601
Closed
Assignees

Comments

@dshemetov
Copy link
Contributor

dshemetov commented May 1, 2024

Alright, I added a validate_epi_archive and moved a bulk of the validation from new_epi_archive in there. Now as_epi_archive calls validate and then new. new_epi_archive is only used there, so this change should be fine for now, but in the future we can refactor some safe internal calls to as_epi_archive with new_epi_archive. There is still a bunch of validation and construction of the data.table object in new_epi_archive, so that's another thing that could be fixed.

I also made clobberable_versions_start default to NULL and then I set it to NA in that case. Just went with the consistent option for now, though we can easily switch it later.

Originally posted by @dshemetov in #431 (comment)

@brookslogan
Copy link
Contributor

brookslogan commented Jan 22, 2025

As part of making compactify_tol more accessible [to more conveniently test some other changes], I'm rearranging things to better align with the pattern here and cleaning up some duplicate validation code. I don't see it being used within other package code except for epix_merge(); I won't touch that for now. [So I doubt we'll get performance benefit from this refactor.] (Seems clobberable_versions_start's default is NA now, so no worries about when NULL -> NA should be handled.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants