Skip to content

deprecate internal arg_check funs in favour of {checkmate}? #403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dajmcdon opened this issue Jan 25, 2024 · 2 comments
Closed

deprecate internal arg_check funs in favour of {checkmate}? #403

dajmcdon opened this issue Jan 25, 2024 · 2 comments
Assignees
@dshemetov

Comments

@dajmcdon
Copy link
Contributor

dajmcdon commented Jan 25, 2024 •
edited
Loading

suggestion (optional): Looks like these type-check fns could be replaced by checkmate::assert_double or checkmate::check_double if you want to raise a custom error message, and analogues for other types.

Originally posted by @nmdefries in #382 (comment)
@dajmcdon dajmcdon mentioned this issue Jan 25, 2024
Merged
@dshemetov
Copy link
Contributor

I'm happy to take a stab at this, did a lot of this work in epidatr.

@dshemetov dshemetov self-assigned this Jan 26, 2024
This was referenced Jan 26, 2024
Merged
Merged
@dshemetov
Copy link
Contributor

Done in #410

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dshemetov dshemetov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dshemetov @dajmcdon