Skip to content

Make vignette building faster #363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nmdefries opened this issue Oct 26, 2023 · 1 comment · Fixed by #538
Closed

Make vignette building faster #363

nmdefries opened this issue Oct 26, 2023 · 1 comment · Fixed by #538
Assignees
Labels
cleanup improvements to developing&building experience&quality, not directly to built pkg&docs documentation Improvements or additions to documentation P2 low priority

Comments

@nmdefries
Copy link
Contributor

Make vignette building work at interactive speeds.

Most vignettes take ~10s to build, and growth_rate.Rmd and compactify.Rmd are major time hogs, taking ~1min a piece. build_vignettes() takes around 3min.

More context here.

@nmdefries nmdefries added documentation Improvements or additions to documentation P2 low priority cleanup improvements to developing&building experience&quality, not directly to built pkg&docs labels Oct 26, 2023
@nmdefries
Copy link
Contributor Author

On my computer, all vignettes build in 2 min. Slowest builds are: growth_rate.Rmd at 1 min, slide.Rmd at 21 s, compactify.Rmd at 17 s.

Profiling all the code in growth_rate.Rmd, most (~75%) of the time is spent doing actual modeling/fitting steps. So this will be hard to speed up, other than just using less data.

Screenshot from 2023-12-15 14-57-12

cv.trendfilter and trendfilter are only used in one branch of growth_rate(), so maybe we can do fewer examples using those settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup improvements to developing&building experience&quality, not directly to built pkg&docs documentation Improvements or additions to documentation P2 low priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants