Skip to content

Remove, use, or require empty dots in new_epi_df #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
brookslogan opened this issue Mar 20, 2023 · 0 comments · Fixed by #472
Closed

Remove, use, or require empty dots in new_epi_df #281

brookslogan opened this issue Mar 20, 2023 · 0 comments · Fixed by #472
Labels
enhancement New feature or request P3 very low priority

Comments

@brookslogan
Copy link
Contributor

The dots (...) in new_epi_df are unused. Misspelling argument names or forgetting the interface can result in swapping in defaults rather than raising an error. (E.g., new_epi_df(....., other_keys = "age_group") --- this is not the current way to set other_keys metadata, but will not raise an error, instead continuing on without setting this metadata.)

We should either remove the dots arg altogether, use it in some way, or check that it is empty. Last part could use ellipsis::check_dots_empty() if its messages are all right or rlang::dots_n(...) with custom messaging.

@brookslogan brookslogan added enhancement New feature or request P3 very low priority labels Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P3 very low priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant