Skip to content

Fix RNG reproducibility wrapper around non-RNG quantity #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
brookslogan opened this issue Mar 2, 2023 · 0 comments · Fixed by #538
Closed

Fix RNG reproducibility wrapper around non-RNG quantity #270

brookslogan opened this issue Mar 2, 2023 · 0 comments · Fixed by #538
Assignees
@dshemetov
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers P3 very low priority

Comments

@brookslogan
Copy link
Contributor

brookslogan commented Mar 2, 2023 •
edited
Loading

In the "get started" vignette, there is the following bit of code:

withr::with_rng_version("3.0.0", withr::with_seed(42, length(state)))

This presumably should have been one of the following:

  • something like runif(length(state))
  • just some arbitrary number or sequence without the with_rng_version and with_seed
@brookslogan brookslogan added documentation Improvements or additions to documentation good first issue Good for newcomers P3 very low priority labels Mar 2, 2023
@dshemetov dshemetov mentioned this issue Oct 15, 2024
Merged
4 tasks
@dshemetov dshemetov self-assigned this Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dshemetov dshemetov

Labels
documentation Improvements or additions to documentation good first issue Good for newcomers P3 very low priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

doc: documentation rework cmu-delphi/epiprocess
2 participants
@dshemetov @brookslogan