Skip to content

Consider including time series completion code in vignettes #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
brookslogan opened this issue Oct 24, 2022 · 1 comment · Fixed by #538
Closed

Consider including time series completion code in vignettes #239

brookslogan opened this issue Oct 24, 2022 · 1 comment · Fixed by #538
Assignees
Labels
documentation Improvements or additions to documentation P2 low priority

Comments

@brookslogan
Copy link
Contributor

E.g., in archive.Rmd, there is a plot that, for some data sources or circumstances, might have gaps that are plotted improperly by geom_line (but don't appear to have gaps in this particular case, when the vignettes are run today). Consider using the group_by complete full_seq pattern, if nothing else but to demonstrate it for users. It's not only archive.Rmd needing potential changes; we'll need to determine where all such a change belongs.

@brookslogan brookslogan added documentation Improvements or additions to documentation P2 low priority labels Oct 24, 2022
@brookslogan
Copy link
Contributor Author

May also want to show a full-key complete pattern, and show difference vs. group_by complete.

@dshemetov dshemetov self-assigned this Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation P2 low priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants