Skip to content

Describe accepted return types/classes of f in epi[x]_slide roxygen #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
brookslogan opened this issue Oct 21, 2022 · 2 comments · Fixed by #538
Closed

Describe accepted return types/classes of f in epi[x]_slide roxygen #234

brookslogan opened this issue Oct 21, 2022 · 2 comments · Fixed by #538
Assignees
Labels
documentation Improvements or additions to documentation P0 high priority

Comments

@brookslogan
Copy link
Contributor

brookslogan commented Oct 21, 2022

There are constraints on the functions f that we accept in the slide functions. We need to describe this in the docs.

The code is hard to parse and hard to say what is actually accepted in f.

@brookslogan brookslogan added documentation Improvements or additions to documentation P0 high priority labels Oct 21, 2022
@dshemetov dshemetov self-assigned this Oct 24, 2023
@dshemetov
Copy link
Contributor

dshemetov commented Jan 23, 2024

@nmdefries @brookslogan any suggestions for how to tackle this? Docs in question.

@brookslogan
Copy link
Contributor Author

I'm guessing this will involve some amount of rooting through source code and testing. And some may be in flux with epi_slide() work.

Check:

  • For tidyeval way: can we output vectors? tibbles? lists of tibbles or other things?
  • For non-tidyeval way: same questions
  • What lengths/nrows can we output? (epi_slide has more demands here; either 1 or the number it's thinking of; epix_slide shouldn't)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation P0 high priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants