You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Unlike geo_value and time_value, we can potentially drop a key column from other_keys and still get a sensible epi_df. This epi_df should not have other_keys that refer to nonexistent columns, though; any key columns that have been selected out from the table data should also be removed from other_keys. A more difficult question is what to do if removing this key column has taken us from a valid unique key to a nonunique key; we have other checks in [ designed to decay to tibble in those cases, but are lax about enforcing a unique key elsewhere, including in epi_df construction.
Additionally, we should consider adding names<- and dimnames<- implementations in order to update other_keys metadata when other_keys are renamed, or decay to tibble when {geo,time}_value are renamed.
Marking P2 as induced bugs probably will trigger errors rather than incorrect behavior, and I don't know if it's causing common issues downstream in epipredict or not.
The text was updated successfully, but these errors were encountered:
Taken from discussion on #185.
Created on 2022-08-08 by the reprex package (v2.0.1)
Unlike
geo_value
andtime_value
, we can potentially drop a key column fromother_keys
and still get a sensibleepi_df
. Thisepi_df
should not haveother_keys
that refer to nonexistent columns, though; any key columns that have been selected out from the table data should also be removed fromother_keys
. A more difficult question is what to do if removing this key column has taken us from a valid unique key to a nonunique key; we have other checks in[
designed to decay to tibble in those cases, but are lax about enforcing a unique key elsewhere, including inepi_df
construction.Additionally, we should consider adding
names<-
anddimnames<-
implementations in order to updateother_keys
metadata whenother_keys
are renamed, or decay to tibble when{geo,time}_value
are renamed.Marking P2 as induced bugs probably will trigger errors rather than incorrect behavior, and I don't know if it's causing common issues downstream in epipredict or not.
The text was updated successfully, but these errors were encountered: