Skip to content

Data variables don't store all the right values (at least archive_cases_dv_subset) #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kenmawer opened this issue Jul 19, 2022 · 3 comments
Labels
bug Something isn't working duplicate This issue or pull request already exists P1 medium priority

Comments

@kenmawer
Copy link
Contributor

kenmawer commented Jul 19, 2022

archive_cases_dv_subset behaves differently from as_epi_archive(archive_cases_dv_subset$DT), as the former does not have column names defined, as noted by what shows up when calling (i.e. printing) the objects. I suspect that other data objects have similar problems, too.

Note: this may be related to or even a duplicate of #125; I still need to confirm that this is the case though.

@kenmawer kenmawer added bug Something isn't working P1 medium priority labels Jul 20, 2022
@brookslogan
Copy link
Contributor

brookslogan commented Jul 22, 2022

Even with the fix for #125 included in [#101], this will still be different, as I have kept archive_cases_dv_subet uncompactified to not break some tests, and the latter expression will compactify+warn. We should sometime make the tests not dependent on this data object so we are free to compactify=TRUE in the data object generation + do other changes to the data object without impacting the tests.

@kenmawer
Copy link
Contributor Author

kenmawer commented Jul 22, 2022

For this, I assumed neither uses compactify, as though compactify were never implemented.

@brookslogan
Copy link
Contributor

Okay, then I believe this is a consequence of #125 and resolved by changes that are included in #101. Marking as duplicate of #125, closing.

@brookslogan brookslogan closed this as not planned Won't fix, can't repro, duplicate, stale Jul 25, 2022
@brookslogan brookslogan added the duplicate This issue or pull request already exists label Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working duplicate This issue or pull request already exists P1 medium priority
Projects
None yet
Development

No branches or pull requests

2 participants