Skip to content

Improving printing of epi_archives with NA's #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
kenmawer opened this issue Jun 16, 2022 · 3 comments · Fixed by #156
Open

Improving printing of epi_archives with NA's #106

kenmawer opened this issue Jun 16, 2022 · 3 comments · Fixed by #156
Labels
bug Something isn't working good first issue Good for newcomers P2 low priority REPL Improved print, errors, etc.

Comments

@kenmawer
Copy link
Contributor

kenmawer commented Jun 16, 2022 •
edited
Loading

When calling an epi_archive, if there's an NA value in the time_value or version, the information given about the minimal and maximal values shows up as an NA rather than ignoring those values. The NA's should be treated as though they did not even exist, as these values are not applicable regardless.
@kenmawer kenmawer changed the title Improving handling of NA Improving handling of data relating to NA's in epi_archives Jun 16, 2022
@kenmawer kenmawer added enhancement New feature or request good first issue Good for newcomers labels Jun 16, 2022
@kenmawer kenmawer changed the title Improving handling of data relating to NA's in epi_archives Improving printing of epi_archives with NA's Jun 16, 2022
@brookslogan brookslogan added P2 low priority REPL Improved print, errors, etc. bug Something isn't working and removed enhancement New feature or request labels Jun 21, 2022
@brookslogan
Copy link
Contributor

We probably shouldn't be able to construct an epi_archive containing any NA version to begin with, or it should have a special, documented, tested meaning. Currently, if NA versions may cause some unintended behavior for LOCF operations. As for time_value (and geo_value), I guess NAs might be all right... maybe they want to use the versioning mechanism for something constant in time, and this is a workaround the geo&time value requirement to get a more general version-tracking mechanism.

@brookslogan brookslogan mentioned this issue Jun 21, 2022
Closed
9 tasks
@dajmcdon dajmcdon mentioned this issue Jun 28, 2022
Merged
@brookslogan
Copy link
Contributor

NA versions are being disallowed in another PR, so I think it's just the time value printing to implement here.

@nmdefries nmdefries mentioned this issue Jul 21, 2022
Merged
@brookslogan brookslogan reopened this Jul 28, 2022
@brookslogan
Copy link
Contributor

The PR I thought handled the version validation and printing part of this doesn't seem to have it. Reopening as a reminder to check on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers P2 low priority REPL Improved print, errors, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ignore NAs when printing an archive's min/max time_value cmu-delphi/epiprocess
3 participants
@brookslogan @nmdefries @kenmawer