Skip to content

Commit 28c9a90

Browse files
committed
docs(update_is_locf): missing @param, better naming
1 parent 2e5f6fe commit 28c9a90

File tree

2 files changed

+7
-4
lines changed

2 files changed

+7
-4
lines changed

R/archive.R

+4-3
Original file line numberDiff line numberDiff line change
@@ -442,20 +442,21 @@ removed_by_compactify <- function(updates_df, ukey_names, abs_tol) {
442442
#' `filter` or `mutate`) being run on an `epi_archive`'s `DT` or a data frame
443443
#' formatted like one.
444444
#'
445+
#' @param arranged_updates_df an arranged update data frame like an `epi_archive` `DT`
445446
#' @param ukey_names (not validated:) chr; the archive/equivalent
446447
#' [`key_colnames`]; must include `"version"`.
447448
#' @param abs_tol (not validated:) as in [`apply_compactify`]
448449
#'
449450
#' @return lgl
450451
#'
451452
#' @keywords internal
452-
update_is_locf <- function(updates_df, ukey_names, abs_tol) {
453+
update_is_locf <- function(arranged_updates_df, ukey_names, abs_tol) {
453454
# Use as.list to get a shallow "copy" in case of data.table, so that column
454455
# selection does not copy the column contents. Don't leak these column aliases
455456
# or it will break data.table ownership model.
456-
updates_col_refs <- as.list(updates_df)
457+
updates_col_refs <- as.list(arranged_updates_df)
457458

458-
all_names <- names(updates_df)
459+
all_names <- names(arranged_updates_df)
459460
ekt_names <- ukey_names[ukey_names != "version"]
460461
val_names <- all_names[!all_names %in% ukey_names]
461462

man/update_is_locf.Rd

+3-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)