From bb434e7b12d16fe75c24913ecd98de737755177a Mon Sep 17 00:00:00 2001 From: "Daniel J. McDonald" Date: Fri, 14 Apr 2023 16:04:26 -0700 Subject: [PATCH 1/2] minor engine problems, DONE! --- R/make_quantile_reg.R | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/R/make_quantile_reg.R b/R/make_quantile_reg.R index fc3a411ae..4fbe0ded1 100644 --- a/R/make_quantile_reg.R +++ b/R/make_quantile_reg.R @@ -4,7 +4,7 @@ #' @description #' `quantile_reg()` generates a quantile regression model _specification_ for #' the [tidymodels](https://www.tidymodels.org/) framework. Currently, the -#' only supported engine is [quantreg::rq()]. +#' only supported engine is "rq" which uses [quantreg::rq()]. #' #' @param mode A single character string for the type of model. #' The only possible value for this model is "regression". @@ -49,15 +49,15 @@ quantile_reg <- function(mode = "regression", engine = "rq", tau = 0.5) { ) } - make_quantile_reg <- function() { parsnip::set_new_model("quantile_reg") parsnip::set_model_mode("quantile_reg", "regression") - parsnip::set_model_engine("quantile_reg", "regression", eng = "rq") - parsnip::set_dependency("quantile_reg", eng = "rq", pkg = "quantreg") + parsnip::set_model_engine("quantile_reg", "regression", eng = "rq") + parsnip::set_dependency("quantile_reg", eng = "rq", pkg = "quantreg") + parsnip::set_model_arg( model = "quantile_reg", eng = "rq", @@ -73,10 +73,12 @@ make_quantile_reg <- function() { mode = "regression", value = list( interface = "formula", - protect = c("formula", "data"), + protect = c("formula", "data", "weights"), func = c(pkg = "quantreg", fun = "rq"), - defaults = list(method = "br", na.action = stats::na.omit, - model = FALSE) + defaults = list( + method = "br", + na.action = rlang::expr(stats::na.omit), + model = FALSE) ) ) From b19e47f80b06604dc2cb67e5d27cd56aebcf41f9 Mon Sep 17 00:00:00 2001 From: "Daniel J. McDonald" Date: Wed, 10 May 2023 13:54:09 -0700 Subject: [PATCH 2/2] redocument --- man/quantile_reg.Rd | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/man/quantile_reg.Rd b/man/quantile_reg.Rd index 63547a683..dce711455 100644 --- a/man/quantile_reg.Rd +++ b/man/quantile_reg.Rd @@ -19,7 +19,7 @@ quantiles to estimate (default is 0.5).} \description{ \code{quantile_reg()} generates a quantile regression model \emph{specification} for the \href{https://www.tidymodels.org/}{tidymodels} framework. Currently, the -only supported engine is \code{\link[quantreg:rq]{quantreg::rq()}}. +only supported engine is "rq" which uses \code{\link[quantreg:rq]{quantreg::rq()}}. } \examples{ tib <- data.frame(y = rnorm(100), x1 = rnorm(100), x2 = rnorm(100))