Skip to content

get_test_data() should return an ungrouped epi_df #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dajmcdon opened this issue Jun 10, 2022 · 5 comments · Fixed by #48
Closed

get_test_data() should return an ungrouped epi_df #45

dajmcdon opened this issue Jun 10, 2022 · 5 comments · Fixed by #48
Assignees
Labels
bug Something isn't working

Comments

@dajmcdon
Copy link
Contributor

  1. Ensure that the result of get_test_data() in ungrouped.
  2. Add a test to check that this is true.
@dajmcdon dajmcdon added the bug Something isn't working label Jun 10, 2022
@ChloeYou
Copy link
Contributor

@dajmcdon do you mean to ungroup by geo_value?

@ChloeYou
Copy link
Contributor

I'll fix this right away! What kind of downstream issues would it cause, just curious?

@dajmcdon
Copy link
Contributor Author

Yes, exactly. Currently, the object that comes out is a grouped epi_df and it needs to be ungrouped.

(Also, it should really be grouped/sliced by geo_value and any additional_metadata$other_keys. You can use epi_keys() to grab the keys.)

Downstream, the grouping can break the more complicated behaviours needed at prediction time when you start doing the postprocessing. The grouping gums it up (hard for me to explain).

@ChloeYou
Copy link
Contributor

I see. Thanks for explaining! I'll change the grouping as well then.

@ChloeYou
Copy link
Contributor

@dajmcdon I don't think time_value should be included in the grouping right? or else the slice_tail is also grouped by time value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants