-
Notifications
You must be signed in to change notification settings - Fork 10
default
value isn't used by epi_lag
or epi_ahead
#338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
The set of arguments is meant to match https://recipes.tidymodels.org/reference/step_lag.html. But there are no values to fill. It is safe to remove this. |
I was going to add support for it, since that's basically the same amount of work; would you rather it be gone? |
Actually, "support" is probably better if it's not too difficult. I think NAs get introduced on the |
Fairly minor problem but neither actually passes the default value through
add_shifted_columns
toepi_shift_single
The text was updated successfully, but these errors were encountered: