Skip to content

default value isn't used by epi_lag or epi_ahead #338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dsweber2 opened this issue Jun 14, 2024 · 4 comments
Open

default value isn't used by epi_lag or epi_ahead #338

dsweber2 opened this issue Jun 14, 2024 · 4 comments

Comments

@dsweber2
Copy link
Contributor

Fairly minor problem but neither actually passes the default value through add_shifted_columns to epi_shift_single

@dsweber2
Copy link
Contributor Author

see

ok <- object$keys
shifted <- reduce(
pmap(grid, epi_shift_single, x = new_data, key_cols = ok),
dplyr::full_join,
by = ok
)

soft block by #296, since that refactors these into a single function, which would make this significantly more awkward

@dajmcdon
Copy link
Contributor

The set of arguments is meant to match https://recipes.tidymodels.org/reference/step_lag.html. But there are no values to fill. It is safe to remove this.

@dsweber2
Copy link
Contributor Author

I was going to add support for it, since that's basically the same amount of work; would you rather it be gone?

@dajmcdon
Copy link
Contributor

Actually, "support" is probably better if it's not too difficult. I think NAs get introduced on the left_join()? And then it's just a matter of replacing them (and not others).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants