Skip to content

bug: severe latency forecasting warning not displaying #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dshemetov opened this issue Apr 24, 2024 · 5 comments
Closed

bug: severe latency forecasting warning not displaying #322

dshemetov opened this issue Apr 24, 2024 · 5 comments

Comments

@dshemetov
Copy link
Contributor

Originally posted by @dajmcdon in #319 (comment)

There is supposed to be a warning when you try to train and forecast on data with a severe latency, but it has stopped showing up. Investigate and bring back?

@dsweber2
Copy link
Contributor

I'm not sure that actually exists yet, as latency "doesn't exist" at the moment. I'm adding one in step_adjust_latency, but that's not on dev yet

@dshemetov
Copy link
Contributor Author

Take a look at that comment, there's some text in the vignettes that comments on such a warning, maybe I misunderstood, but that warning is not showing up for the same code anymore 🤷

@dajmcdon
Copy link
Contributor

I removed that warning, because it was annoying. All it did was always warn if the epi_df had as_of < today().

@dshemetov
Copy link
Contributor Author

Oh that makes sense. I figured it checked if as_of < today() - 90 or something. Is a warning with a better threshold something we want in principle or should we just scrap this?

@dajmcdon
Copy link
Contributor

I think scrap it completely. The print methods will show all this information.

@dshemetov dshemetov closed this as not planned Won't fix, can't repro, duplicate, stale Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants