Skip to content

Add training window option to arx_forecaster #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
brookslogan opened this issue Apr 26, 2023 · 1 comment · Fixed by #180
Closed

Add training window option to arx_forecaster #171

brookslogan opened this issue Apr 26, 2023 · 1 comment · Fixed by #180
Labels
enhancement New feature or request

Comments

@brookslogan
Copy link
Contributor

As @dshemetov and I were comparing some production forecasters to epipredict canned forecasters, it seemed like it would be useful to have a training window as a parameter (implemented via step_training_window).

Some asides:

  • Does step_training_window need to be step_epi_training_window, since it relies on epi_keys and time_value?
  • I've been using "epikey" (or "epigroup") to refer to the geographical&demographical keys, not including time_value or version, but I think epipredict considers time_value an epikey. We should think about standardizing names.
@brookslogan brookslogan added the enhancement New feature or request label Apr 26, 2023
@brookslogan
Copy link
Contributor Author

Alternatively: add a function to output the unfit workflow that would be used by arx_forecaster(), have utilities to modify the workflow more easily ([add_]step*(.after = "<step/phasename>", .before = "<step/phasename>", ....)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant